qtubuntu-media

Merge lp://staging/~jhodapp/qtubuntu-media/fix-1438115 into lp://staging/qtubuntu-media

  1. fix-1438115
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 73
Merged at revision: 72
Proposed branch: lp://staging/~jhodapp/qtubuntu-media/fix-1438115
Merge into: lp://staging/qtubuntu-media
Diff against target: 47 lines (+8/-2)
2 files modified
src/aal/aalmediaplayercontrol.cpp (+2/-2)
src/aal/aalmediaplayerservice.cpp (+6/-0)
To merge this branch: bzr merge lp://staging/~jhodapp/qtubuntu-media/fix-1438115
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Manuel de la Peña (community) Approve
Review via email: mp+257695@code.staging.launchpad.net

Commit message

Fix duration() not getting reported after playback starts.

Description of the change

Fix duration() not getting reported after playback starts.

To post a comment you must log in.
lp://staging/~jhodapp/qtubuntu-media/fix-1438115 updated
73. By Jim Hodapp

Remove unnecessary qDebug

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:72
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/109/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/34/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/34/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/34/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/109/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
lp://staging/~jhodapp/qtubuntu-media/fix-1438115 updated
74. By Jim Hodapp

Emit durationChanged() signal before setting player state to Playing to fix race on Arale.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:72
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/111/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/36/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/111/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~jhodapp/qtubuntu-media/fix-1438115 updated
75. By Jim Hodapp

Make sure updateCachedDuration() emits emitDurationChanged(). Also don't signal durationChanged(0) when the media has been prepared.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches