qtubuntu-media

Merge lp://staging/~jhodapp/qtubuntu-media/fix-1438115-take2 into lp://staging/qtubuntu-media

  1. fix-1438115-take2
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Approved
Approved by: Alfonso Sanchez-Beato
Approved revision: 78
Proposed branch: lp://staging/~jhodapp/qtubuntu-media/fix-1438115-take2
Merge into: lp://staging/qtubuntu-media
Diff against target: 85 lines (+16/-1)
5 files modified
debian/control (+1/-1)
src/aal/aalmediaplayerservice.cpp (+7/-0)
src/aal/aalmediaplayerservice.h (+1/-0)
unittests/player.cpp (+6/-0)
unittests/player.h (+1/-0)
To merge this branch: bzr merge lp://staging/~jhodapp/qtubuntu-media/fix-1438115-take2
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Alfonso Sanchez-Beato Approve
Review via email: mp+259178@code.staging.launchpad.net

Commit message

Signal to the client QML app when the duration has changed.

Description of the change

Signal to the client QML app when the duration has changed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:76
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/112/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/37/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/37/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/37/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/112/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:76
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/113/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/38/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/38/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/38/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/113/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~jhodapp/qtubuntu-media/fix-1438115-take2 updated
77. By Jim Hodapp

Bump the libmedia-hub-dev package dependency version.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:77
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/114/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/39/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/39/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/39/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/114/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM, just one comment, see above.

review: Needs Fixing
Reply
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

See inline comment.

Reply
lp://staging/~jhodapp/qtubuntu-media/fix-1438115-take2 updated
78. By Jim Hodapp

Address review comment of the need for a comment on the units of emitDurationChanged()

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:77
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/115/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/40/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/40/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/40/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/115/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

78. By Jim Hodapp

Address review comment of the need for a comment on the units of emitDurationChanged()

77. By Jim Hodapp

Bump the libmedia-hub-dev package dependency version.

76. By Jim Hodapp

Signal to the client QML app when the duration has changed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches