qtubuntu-media

Merge lp://staging/~jhodapp/qtubuntu-media/fix-1435088 into lp://staging/qtubuntu-media

  1. fix-1435088
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Merged
Approved by: Nick Dedekind
Approved revision: 72
Merged at revision: 74
Proposed branch: lp://staging/~jhodapp/qtubuntu-media/fix-1435088
Merge into: lp://staging/qtubuntu-media
Diff against target: 33 lines (+6/-4)
2 files modified
src/aal/aalmediaplayercontrol.cpp (+4/-1)
src/aal/aalmediaplayerservice.cpp (+2/-3)
To merge this branch: bzr merge lp://staging/~jhodapp/qtubuntu-media/fix-1435088
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+258076@code.staging.launchpad.net

Commit message

Make sure that stopped and ready (same state for QMediaPlayer) are reported to the client app.

Description of the change

Make sure that stopped and ready (same state for QMediaPlayer) are reported to the client app.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:72
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/110/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/35/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/35/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/35/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/110/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

24 + qDebug() << "PlaybackStatus changed to: " << m_newStatus;

you want this debug message?

review: Needs Information
Revision history for this message
Jim Hodapp (jhodapp) wrote :

> 24 + qDebug() << "PlaybackStatus changed to: " << m_newStatus;
>
> you want this debug message?

Yes I do, that's definitely on purpose and quite useful for some of the types of issues the media stack has been having lately.

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Ok, all good then :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches