Unifield Server

Merge lp://staging/~jfb-tempo-consulting/unifield-server/us-3808 into lp://staging/~julie-w/unifield-server/US-3808

  1. us-3808
  2. Merge into US-3808
Proposed by jftempo
Status: Needs review
Proposed branch: lp://staging/~jfb-tempo-consulting/unifield-server/us-3808
Merge into: lp://staging/~julie-w/unifield-server/US-3808
Diff against target: 63 lines (+11/-20)
1 file modified
bin/addons/msf_partner/partner.py (+11/-20)
To merge this branch: bzr merge lp://staging/~jfb-tempo-consulting/unifield-server/us-3808
Reviewer Review Type Date Requested Status
Julie Nuguet Pending
Review via email: mp+337076@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
jftempo (jfb-tempo-consulting) wrote :

Julie,

Here is a proposal to change the code:
  - test condition after write / creation so we don't have to play with vals['address'][0][2]
  - do not change the context (active_test) as it can be used in the following code.

Do you agree ?

Reply
Revision history for this message
jftempo (jfb-tempo-consulting) wrote :

Last point: the check is done on creation (as requested in the ticket), but also on modification.
It can result in an error msg if a process tries to write something in a duplicated partner (for example Action "Reconciliation: Go to Next Partner" from JI form view).

Reply

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: