Rhythmbox

Merge lp://staging/~jerico-dev/rhythmbox/rb-ipod-support-video-podcast into lp://staging/~ubuntu-desktop/rhythmbox/lucid

  1. rb-ipod-support-video-podcast
  2. Merge into lucid
Proposed by jerico
Status: Rejected
Rejected by: Robert Ancell
Proposed branch: lp://staging/~jerico-dev/rhythmbox/rb-ipod-support-video-podcast
Merge into: lp://staging/~ubuntu-desktop/rhythmbox/lucid
Diff against target: 159 lines (+147/-0)
2 files modified
debian/changelog (+7/-0)
debian/patches/95_rb_ipod_support_video_podcast.patch (+140/-0)
To merge this branch: bzr merge lp://staging/~jerico-dev/rhythmbox/rb-ipod-support-video-podcast
Reviewer Review Type Date Requested Status
Robert Ancell Needs Information
Javier Jardón Pending
Review via email: mp+29183@code.staging.launchpad.net

Description of the change

Introduces video podcast support for iPods, e.g. Nano 5G. The patch has also been posted upstream, see https://bugzilla.gnome.org/show_bug.cgi?id=412841#c3. It would be great, though, to have this in Ubuntu already until it's integrated upstream.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Does this patch affect the Rhythmbox on-disk database? I ask because if upstream does not take this patch or modifies it will there be compatibility issues with the database on upgrade?

review: Needs Information
Revision history for this message
jerico (jerico-dev) wrote :

Hi Robert, this patch introduces the new field RHYTHMDB_PROP_HAS_VIDEO. I had a quick email exchange with upstream maintainer Jonathan Matthew about the patch. He thinks that yes, there might be upgrade problems. He says: "This feature involves some changes that we need to be very careful with, so we really need to do this upstream first." And I agree with him.

Jonathan promised to get back to me with a more detailed review of the patch at the time I submitted the merge request. But I guess he didn't have time yet. BTW: It seems I'm not the only one interested in this change coming out: https://bugzilla.gnome.org/show_bug.cgi?id=363822.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Ok, rejecting this patch due to the upgrade problems. I look forward to seeing this feature in 11.04!

Unmerged revisions

3. By Florian Grandel <fgrandel@laptop-fg>

* debian/patches/95_rb_ipod_support_video_podcast.patch:
  - added support for video podcasts

2. By Florian Grandel <fgrandel@laptop-fg>

- Added a RhythmDB entry property "has-video" that will be true when a file contains a video track
- The "has-video" property will be queried when adding podcasts to an iPod. The file's media type will be set to "video podcast" if true. This is required to support iPod video podcasts, e.g. on iPod Nano 5G.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: