Merge lp://staging/~jeremywootten/scratch/fix-1592699-focus-search-box into lp://staging/~elementary-apps/scratch/scratch
Proposed by
Jeremy Wootten
| Status: | Merged |
|---|---|
| Approved by: | Zisu Andrei |
| Approved revision: | 1691 |
| Merged at revision: | 1705 |
| Proposed branch: | lp://staging/~jeremywootten/scratch/fix-1592699-focus-search-box |
| Merge into: | lp://staging/~elementary-apps/scratch/scratch |
| Diff against target: |
154 lines (+52/-32) 3 files modified
src/MainWindow.vala (+48/-29) src/Widgets/ToolBar.vala (+1/-1) src/scratch-ui.xml (+3/-2) |
| To merge this branch: | bzr merge lp://staging/~jeremywootten/scratch/fix-1592699-focus-search-box |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zisu Andrei (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Do not toggle search entry with Ctrl-F
Description of the change
This branch splits the "Fetch" action into two - one a toggle action and one not. The toggle action remains linked to the Toolbar edit-find togglebutton. However, the keyboard shortcut Ctrl-f now triggers the standard action which shows and focuses the search entry if it is hidden otherwise just focuses it.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Pressing the headerbar button seems to work alright, but pressing ctrl+f seems to not work. I tried debugging it but am unsure.