Files

Merge lp://staging/~jeremywootten/pantheon-files/use-hardware-keycodes into lp://staging/~elementary-apps/pantheon-files/trunk

  1. use-hardware-keycodes
  2. Merge into trunk
Proposed by Jeremy Wootten
Status: Merged
Approved by: Cody Garver
Approved revision: 2341
Merged at revision: 2353
Proposed branch: lp://staging/~jeremywootten/pantheon-files/use-hardware-keycodes
Merge into: lp://staging/~elementary-apps/pantheon-files/trunk
Diff against target: 271 lines (+98/-55)
1 file modified
src/View/AbstractDirectoryView.vala (+98/-55)
To merge this branch: bzr merge lp://staging/~jeremywootten/pantheon-files/use-hardware-keycodes
Reviewer Review Type Date Requested Status
Corentin Noël layout: fr_fr Approve
Zisu Andrei (community) Needs Fixing
Review via email: mp+307873@code.staging.launchpad.net

Commit message

Instead of using event.keyval directly, translate event.hardware_keycode using the default Gdk.Keymap when processing View key press events and then try to match the hardware code and level to an ASCII hotkey

Description of the change

Instead of using event.keyval directly, translate event.hardware_keycode using the default Gdk.Keymap when processing View key press events and then try to match the hardware code and level to an ASCII hotkey.

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

I cannot confirm this fixes the issue.

Tested it by using a Russian keyboard setting on my US keyboard. I pressed ctrl-c and nothing happened.

review: Needs Fixing
Revision history for this message
Corentin Noël (tintou) wrote :

No regression here on the French Keyboard.

review: Approve (layout: fr_fr)
Revision history for this message
Zisu Andrei (matzipan) wrote :

Tried russian layout on my US keyboard.

Ctrl+c worked fine. Ctrl+a worked fine too, although I'm not entirely sure if that is correct, since the keyboard character is expected to be "ф".

What are the expectations of a person using a Russian keyboard?

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

I must admit I am not entirely sure of the expectations of users of alternative keyboards/layouts when it comes to hotkeys. E.g. for Ctrl+c (copy), should the key used together with Ctrl be:

1) the key with "c" printed on it (if there is one) or
2) the key [combination] which generates a printed "c" (if different) or
3) the key which is in the same position as the "c" key on a US keyboard (if different).

Revision history for this message
Maxim Taranov (png2378) wrote :

For Russian layout is correct only the third variant ("the key which is in the same position as the "c" key on a US keyboard"). I'm sure this applies to other international layouts, but I'm not sure about Dvorak.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: