Merge lp://staging/~jeremywootten/pantheon-files/fix-search-while-loading into lp://staging/~elementary-apps/pantheon-files/trunk
Proposed by
Jeremy Wootten
| Status: | Merged |
|---|---|
| Approved by: | Cody Garver |
| Approved revision: | 2192 |
| Merged at revision: | 2316 |
| Proposed branch: | lp://staging/~jeremywootten/pantheon-files/fix-search-while-loading |
| Merge into: | lp://staging/~elementary-apps/pantheon-files/trunk |
| Diff against target: |
978 lines (+236/-165) 9 files modified
libcore/AbstractSlot.vala (+4/-1) libwidgets/Chrome/TopMenu.vala (+20/-11) libwidgets/View/LocationBar.vala (+15/-2) src/View/AbstractDirectoryView.vala (+46/-56) src/View/ColumnView.vala (+5/-4) src/View/Miller.vala (+21/-5) src/View/Slot.vala (+83/-59) src/View/ViewContainer.vala (+18/-13) src/View/Window.vala (+24/-14) |
| To merge this branch: | bzr merge lp://staging/~jeremywootten/pantheon-files/fix-search-while-loading |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zisu Andrei (community) | code and functionality | Approve | |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-06-05.
Commit message
Make the pathbar insensitive and ignore key presses in the view while it is loading or reloading (lp:1588086)
Description of the change
This branch makes the pathbar insensitive and ignores key presses in the view while it is loading or reloading, in order to avoid problems reported with trying to perform a search on a partially loaded large folder.
This also applies to individual slots within a column view.
To post a comment you must log in.
Revision history for this message
| Cody Garver (codygarver) wrote | # |
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote | # |
Revision history for this message
| Zisu Andrei (matzipan) | # |
review:
Approve
(code and functionality)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Conflicts with trunk