Merge lp://staging/~jeremywootten/pantheon-files/fix-1622999-libreoffice-on-smb into lp://staging/~elementary-apps/pantheon-files/trunk

Proposed by Jeremy Wootten
Status: Merged
Approved by: Cody Garver
Approved revision: 2315
Merged at revision: 2329
Proposed branch: lp://staging/~jeremywootten/pantheon-files/fix-1622999-libreoffice-on-smb
Merge into: lp://staging/~elementary-apps/pantheon-files/trunk
Diff against target: 162 lines (+68/-19)
3 files modified
libcore/pantheon-files-core-C.vapi (+1/-4)
libwidgets/MimeActions.vala (+64/-5)
src/View/AbstractDirectoryView.vala (+3/-10)
To merge this branch: bzr merge lp://staging/~jeremywootten/pantheon-files/fix-1622999-libreoffice-on-smb
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+305992@code.staging.launchpad.net

Commit message

Rewrite the code that opens a file with an app (in MimeActions), replacing a call to gof.open_single (). The binding in pantheon-files-Core.vapi is removed to discourage external use of the gof function. This fixes the bug (for reasons that are not entirely clear).

Opening muliple files is also reworked - it is left to the app whether the files are opened in multiple instances or not.

Description of the change

This branch rewrites the code that opens a file with an app (in MimeActions), replacing a call to gof.open_single (). The binding in pantheon-files-Core.vapi is removed to discourage external use of the gof function. This fixes the bug (for reasons that are not entirely clear).

Opening muliple files is also reworked - it is left to the app whether the files are opened in multiple instances or not.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: