Merge lp://staging/~jeremywootten/pantheon-files/fix-1619811-edit-context-menu-in-pathbar into lp://staging/~elementary-apps/pantheon-files/trunk
Proposed by
Jeremy Wootten
| Status: | Merged |
|---|---|
| Approved by: | Zisu Andrei |
| Approved revision: | 2309 |
| Merged at revision: | 2362 |
| Proposed branch: | lp://staging/~jeremywootten/pantheon-files/fix-1619811-edit-context-menu-in-pathbar |
| Merge into: | lp://staging/~elementary-apps/pantheon-files/trunk |
| Diff against target: |
66 lines (+13/-13) 2 files modified
libwidgets/Chrome/BasicBreadcrumbsEntry.vala (+11/-1) libwidgets/View/BreadcrumbsEntry.vala (+2/-12) |
| To merge this branch: | bzr merge lp://staging/~jeremywootten/pantheon-files/fix-1619811-edit-context-menu-in-pathbar |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zisu Andrei (community) | code and functionality | Approve | |
|
Review via email:
|
|||
Commit message
Fix context menu in pathbar edit mode
Description of the change
Stop pathbar resetting when context menu shows (because of focus out event).
To post a comment you must log in.
Revision history for this message
| Zisu Andrei (matzipan) | # |
review:
Approve
(code and functionality)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I click on location bar, and I see the text. When I right the selected text, first problem is that the text becomes black and the selection remains blue. If I do the same thing in Scratch, the text becomes black and the selection becomes gray.
Next, after I close the context menu, when I click on a folder, single-click doesn't work anymore.
When I unfocus the location bar (say, I change the window or click else where in the window), the path breadcrumbs appear, but they somehow overlap the path text.