Merge lp://staging/~jeremy-munsch/synapse-project/fix-notification into lp://staging/synapse-project

Looks reasonable, but do not be lazy! "n" is not a good variable name at all. So "notification" it is.

More of a problem is the implicit bump to glib >= 2.40 which could use some thinking.

Please use descriptive commit messages mainly in the present tense.

"topic/source-target": "short description of the actual change"
\n
"long description if needed"

e.g. "Replace usage of libnotify with GLib.Notification"

And use "bzr --fixes lp:XXXXXX" if a bug is available to reference the bug and don't explicitly mention the bug number in the commit message.

This concerns all your merge-proposals

Ok, thank you for the review, i'll look for these.

Also i just saw https://launchpad.net/ubuntu/+source/glib2.0,
and precise is still at supported until late 2018 https://wiki.ubuntu.com/LTS.

I guess that this merge is dead for now sadly, because GLib is still at 2.32, there might be no workaround this is guess ?

Ok I have now updated my other merge proposals as well as this one with your commit recommendations. :P

Please rebase and test it again. Seems not to work here.

I just put modifications on last branch version and it is working here.

To test it i:
- had a selection and search for text -> send pastebin - OK
- search an image -> send to imgur - OK

No hang, no crash.

OK, it is *not* working here (gnome-shell 3.18.2 and glib 2.27.1) while the existing solution (libnotify) seems to work flawlessly.

I'll make some tests on a virtual machine asap

Just had a few tests on
Ubuntu 15.10 fresh install (libglib 2.46.1-1) - *OK*
Lubuntu 15.10 fresh install (libglib 2.46.1-1) - *OK*
Kubuntu 15.10 (libglib 2.46.1-1) - *OK*

-- Alright, i was about to test debian + gnome DE, but i checked in devhelp as you adviced me once,
i found that there is an implicit bump to glib 2.40, which is actually what you said on #1 lol

So i think it should need a preprocessor instruction on compile to check which method to use.
I'll try to figure out this and update PR.

> Just had a few tests on
> Ubuntu 15.10 fresh install (libglib 2.46.1-1) - *OK*
> Lubuntu 15.10 fresh install (libglib 2.46.1-1) - *OK*
> Kubuntu 15.10 (libglib 2.46.1-1) - *OK*

Hmm, I see. I wonder why it isn't working with my setup.

> -- Alright, i was about to test debian + gnome DE, but i checked in devhelp as
> you adviced me once,
> i found that there is an implicit bump to glib 2.40, which is actually what
> you said on #1 lol
>
> So i think it should need a preprocessor instruction on compile to check which
> method to use.
> I'll try to figure out this and update PR.

You are not making much sense or did you really miss
https://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/revision/618

(It is not a dependency or build problem)

> OK, it is *not* working here (gnome-shell 3.18.2 and glib 2.27.1) while the existing solution > (libnotify) seems to work flawlessly.

> You are not making much sense or did you really miss
> https://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/revision/618
>
> (It is not a dependency or build problem)

Yes it got out of my mind as i saw you had glib < 2.40.

I'm instal fresh debian + Gnome DE right now to make a test

Ah, I am sorry, that was a typo which meant to be "glib 2.47.1"

Just made other tests :
Fedora 23, glib 2.46.1, gnome-shell 3.18.1, valac 0.30 - *Not Working*
Debian Jessy, glib 2.42.1-1, gnome-shell 3.14.4.1.deb8u1, valac {0.26,0.30} - *Not Working*

I think this is obviously a bug,
I ran this sample code:
http://paste.ubuntu.com/13283891/
with valac --pkg=gio-2.0 notif.vala

Tested on all previous VM i mentionned, and it is not workin on fedora and debian.

I'm thinking of filling a bug, still to found from which lib occurs the bug, my guess is it is likely to be gio having a problem with gnome-shell, even this sounds weird; i'm thinking of filling a bug in https://bugzilla.gnome.org.

Is using a fallback method would be acceptable ? It may be checking env var XDG_CURRENT_DESKTOP which is filled by gnome DE with GNOME.

I'll start working on this.

Just tested this solution and it makes every distro happier :)
So both use libnotify and GLib.Notify based on XDG_CURRENT_DESKTOP == "GNOME"

Please reinstantiate your original proposal. I won't accept this conditional stuff anyway.

Maybe look at gnome-clocks which is written in vala and is using GNotification too.

(gnome-clocks' notifications are working here)

Well i checked a few times to really be sure https://mail.gnome.org/archives/commits-list/2013-October/msg08602.html
It seems that GLib.notification is used exactly the same way.
Even the sample code i linked above is not working.

How ever it saw in
https://bugzilla.gnome.org/show_bug.cgi?id=710913
https://wiki.gnome.org/HowDoI/GNotification

> Warning: gnome-shell uses desktop files to find extra information (app icon, name) about the
> sender of the notification. If you don't have a desktop file whose base name matches the
> application id, then your notification will not show up.

> This will be the preferred way of launching applications, so install a
> DBus .service file, rename the .desktop file to use reverse DNS notation
> and mark it as DBus activatable.
> Using reverse DNS notation for the .desktop file is also a prerequisite
> for using GLib's new notification API.

I don't know what are the "reverse DNS notation" and "DBus .service file". I'll try to find more info

As a side-note: "var gicon = new GLib.ThemedIcon ("synapse");"

Just corrected according your side note.

So what i understand, is that to use GLib.Notification with gnome-shell, Synapse has to be DBus launchable at least, yes, I have no idea how to implement that a this time.
What I know is that instead of having a classic fork checking for an existing previous instance, would have to be replaced by a DBus listener, with at least one action.

According to what I read, I could be a small change though, not sure.