Merge jenkins-agent-charm:write-default-bug into jenkins-agent-charm:master

Proposed by Alexandre Gomes
Status: Merged
Approved by: Tom Haddon
Approved revision: d0cf9e96c3bd2e5df2421fa4d663ea2f5680d8ab
Merged at revision: fbb7b371b188e4af787a2b264313684e7308e649
Proposed branch: jenkins-agent-charm:write-default-bug
Merge into: jenkins-agent-charm:master
Diff against target: 42 lines (+19/-1)
2 files modified
reactive/jenkins_slave.py (+1/-1)
tests/unit/test_jenkins_slave.py (+18/-0)
Reviewer Review Type Date Requested Status
Tom Haddon (community) Approve
Canonical IS Reviewers Pending
Review via email: mp+401491@code.staging.launchpad.net

Commit message

Fix template rendering when using default conf

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

Would be good to test this. How about something like https://paste.ubuntu.com/p/ZNvfmRwfQB/ ?

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, thx

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision fbb7b371b188e4af787a2b264313684e7308e649

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: