Merge lp://staging/~jelmer/wikkid/unlock into lp://staging/wikkid

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 37
Proposed branch: lp://staging/~jelmer/wikkid/unlock
Merge into: lp://staging/wikkid
Diff against target: 64 lines (+27/-26)
1 file modified
wikkid/filestore/bzr.py (+27/-26)
To merge this branch: bzr merge lp://staging/~jelmer/wikkid/unlock
Reviewer Review Type Date Requested Status
Tim Penhey Approve
Review via email: mp+26076@code.staging.launchpad.net

Description of the change

This makes the update code always unlock the working tree after it has locked it, even if exceptions occurred halfway through.

Without this change locks are leaked and Bazaar will print warnings if locks are left around. I noticed this while accidentally breaking the update code in one of my branches.

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Thanks. Merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches