lptools

Merge lp://staging/~jelmer/lptools/breezy-python3 into lp://staging/lptools

  1. breezy-python3
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 48
Proposed branch: lp://staging/~jelmer/lptools/breezy-python3
Merge into: lp://staging/lptools
Prerequisite: lp://staging/~jelmer/lptools/breezy
Diff against target: 888 lines (+134/-132)
20 files modified
bin/lp-attach (+9/-9)
bin/lp-bug-dupe-properties (+6/-6)
bin/lp-capture-bug-counts (+5/-5)
bin/lp-check-membership (+4/-4)
bin/lp-force-branch-mirror (+4/-4)
bin/lp-get-branches (+7/-7)
bin/lp-grab-attachments (+2/-2)
bin/lp-list-bugs (+8/-9)
bin/lp-milestone2ical (+4/-4)
bin/lp-milestones (+2/-2)
bin/lp-project (+1/-1)
bin/lp-project-upload (+25/-23)
bin/lp-recipe-status (+7/-7)
bin/lp-remove-team-members (+5/-5)
bin/lp-review-list (+8/-8)
bin/lp-review-notifier (+8/-8)
bin/lp-set-dup (+16/-16)
bin/lp-shell (+8/-8)
lptools/config.py (+1/-1)
setup.py (+4/-3)
To merge this branch: bzr merge lp://staging/~jelmer/lptools/breezy-python3
Reviewer Review Type Date Requested Status
Colin Watson (community) Needs Fixing
dobey Approve
Jelmer Vernooij Approve
Ubuntu One Control Tower Pending
Review via email: mp+372112@code.staging.launchpad.net

Commit message

Convert lptools to Python 3.

Description of the change

Convert lptools to Python 3.

There's probably some things I missed because test coverage is poor, but it should at least be better than the current state of things.

To post a comment you must log in.
lp://staging/~jelmer/lptools/breezy-python3 updated
48. By Jelmer Vernooij

use open rather than file.

49. By Jelmer Vernooij

Fix binaryness.

50. By Jelmer Vernooij

Improve python3 compatibility of lp-project-upload.

Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve
Revision history for this message
dobey (dobey) wrote :

Looks OK. Thanks.

review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

Mostly just a few minor tweaks because I'm a pedant, but I did notice one definite mistake.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches