Merge lp://staging/~jelmer/loggerhead/controller-hook into lp://staging/loggerhead

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 458
Proposed branch: lp://staging/~jelmer/loggerhead/controller-hook
Merge into: lp://staging/loggerhead
Diff against target: 129 lines (+60/-7)
3 files modified
NEWS (+3/-0)
loggerhead/apps/branch.py (+28/-3)
loggerhead/tests/test_controllers.py (+29/-4)
To merge this branch: bzr merge lp://staging/~jelmer/loggerhead/controller-hook
Reviewer Review Type Date Requested Status
Martin Pool Approve
Review via email: mp+80972@code.staging.launchpad.net

Description of the change

Add a hook 'controller' to BranchWSGIApp, allowing other bzr plugins to provide custom branch-specific controllers.

This can be used for several things. It makes it possible to e.g. have bzr stats provide a custom page with branch statistics.

bzr-git/bzr-svn can hook into loggerhead and allow access to bzr branches using their respective protocols. I have a working version of this with bzr-git, using the branch at lp:~jelmer/bzr-git/loggerhead-integration:

$ cd /my/bzr/branch
$ echo http_git=True >> .bzr/branch/branch.conf
$ bzr serve --http &
$ git clone git://localhost:8080/ gitclone

To post a comment you must log in.
460. By Jelmer Vernooij

Add bug #

Revision history for this message
Martin Pool (mbp) wrote :

  vote approve

review: Approve
461. By Jelmer Vernooij

Fix comment.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches