Merge lp://staging/~jelmer/launchpad/use-bzr-policy-open into lp://staging/launchpad
Proposed by
Jelmer Vernooij
| Status: | Rejected |
|---|---|
| Rejected by: | Jelmer Vernooij |
| Proposed branch: | lp://staging/~jelmer/launchpad/use-bzr-policy-open |
| Merge into: | lp://staging/launchpad |
| Prerequisite: | lp://staging/~jelmer/launchpad/bzr-2.5.1 |
| Diff against target: |
1424 lines (+95/-830) 16 files modified
lib/launchpad_loggerhead/app.py (+2/-2) lib/lp/code/bzr.py (+0/-1) lib/lp/code/interfaces/branch.py (+1/-1) lib/lp/code/model/branch.py (+2/-2) lib/lp/code/model/tests/test_branch.py (+3/-3) lib/lp/codehosting/codeimport/tests/test_worker.py (+17/-17) lib/lp/codehosting/codeimport/worker.py (+13/-12) lib/lp/codehosting/puller/tests/__init__.py (+1/-1) lib/lp/codehosting/puller/tests/test_errors.py (+4/-4) lib/lp/codehosting/puller/tests/test_worker.py (+24/-24) lib/lp/codehosting/puller/tests/test_worker_formats.py (+2/-2) lib/lp/codehosting/puller/worker.py (+23/-22) lib/lp/codehosting/safe_open.py (+0/-354) lib/lp/codehosting/scanner/tests/test_bzrsync.py (+2/-2) lib/lp/codehosting/tests/test_safe_open.py (+0/-382) scripts/code-import-worker.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~jelmer/launchpad/use-bzr-policy-open |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| j.c.sackett (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Use new bzrlib.
Description of the change
Launchpad's safe_open API was fairly generic and has been moved into bzrlib as bzrlib.
This branch changes Launchpad to use the copy of safe_open that is present in bzrlib, and removes it from Launchpad itself.
To post a comment you must log in.
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Jelmer--
This looks good, thanks.
One thing: On line 240 of your diff, you have 'svn' listed twice in the list of
allowed_schemes. I assume that's just a typo/editing artifact.