Launchpad itself

Merge lp://staging/~jelmer/launchpad/bug589073 into lp://staging/launchpad/db-devel

  1. bug589073
  2. Merge into db-devel
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 9479
Proposed branch: lp://staging/~jelmer/launchpad/bug589073
Merge into: lp://staging/launchpad/db-devel
Diff against target: 62 lines (+33/-2)
2 files modified
database/schema/security.cfg (+1/-1)
lib/lp/archiveuploader/tests/nascentuploadfile.txt (+32/-1)
To merge this branch: bzr merge lp://staging/~jelmer/launchpad/bug589073
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) code Approve
Review via email: mp+27683@code.staging.launchpad.net

Commit message

Allow archiveuploader to update the emailaddress table.

Description of the change

In rare occassions it may be necessary for the uploader to update an existing emailaddress entry to link it to a person. This is what happened in bug 589073.

This branch gives the archive uploader the permission to update emailaddress entries and updates nascentfileupload.txt to reproduce this situation.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Looks good. Just one note: you'll usually want to use

    >>> print value
    foo

rather than...

    >>> print value
    'foo'

...which can break unnecessarily if the value comes out as u'foo' etc.

review: Approve (code)
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I assume you mean without the "print" on the first line, I've fixed my branch accordingly.

Thanks for the review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: