Merge lp://staging/~jelmer/launchpad/594237-arm-checkbox into lp://staging/launchpad

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 11078
Proposed branch: lp://staging/~jelmer/launchpad/594237-arm-checkbox
Merge into: lp://staging/launchpad
Diff against target: 299 lines (+97/-54)
8 files modified
lib/lp/soyuz/browser/archive.py (+29/-1)
lib/lp/soyuz/configure.zcml (+2/-1)
lib/lp/soyuz/interfaces/archive.py (+6/-2)
lib/lp/soyuz/interfaces/processor.py (+6/-0)
lib/lp/soyuz/model/archive.py (+18/-33)
lib/lp/soyuz/model/processor.py (+5/-0)
lib/lp/soyuz/tests/test_archive.py (+21/-17)
lib/lp/soyuz/tests/test_processor.py (+10/-0)
To merge this branch: bzr merge lp://staging/~jelmer/launchpad/594237-arm-checkbox
Reviewer Review Type Date Requested Status
Leonard Richardson (community) Approve
Review via email: mp+28751@code.staging.launchpad.net

Commit message

Use checkboxes to set the restricted architectures an archive can be built on.

Description of the change

This branch changes the archive administration page to allow changing what restricted architectures the archive can build on. Previously it only allowed enabling restricted ARM builds but there was a bug in the way this was implemented (https://bugs.edge.launchpad.net/soyuz/+bug/594237), while supporting the ability to toggle building on other restricted architectures was always a goal anyway (https://bugs.edge.launchpad.net/soyuz/+bug/531302).

I've added a ProcessorFamilySet.getRestricted() call which will return all restricted architecture families. This is for useful as the vocabulary of the checkboxes.

The existing tests for arm_builds_enabled have been modified to use enabled_restricted_architectures.

The result of this work can be seen on a random PPA admin page - in my case I created one for <email address hidden>:

https://launchpad.dev/~name16/+archive/ppa/+admin

Triggering the ARM checkbox results in an entry in archivearch being created:

launchpad_dev=# select * from archivearch;
 id | archive | processorfamily
----+---------+-----------------
  3 | 14 | 5
(1 row)

To post a comment you must log in.
Revision history for this message
Leonard Richardson (leonardr) wrote :

r=leonardr with changes:

1. On line 44, the arguments to SimpleTerm need to all go on their own line.

2. Don't call exported() on enable_restricted_families. The property it replaces wasn't exported to the web service, and you don't have the code that would publish IProcessorFamily objects on the web service.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.