Merge lp://staging/~jelmer/bzr/transport-segments into lp://staging/bzr
Proposed by
Jelmer Vernooij
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jelmer Vernooij | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 6079 | ||||
Proposed branch: | lp://staging/~jelmer/bzr/transport-segments | ||||
Merge into: | lp://staging/bzr | ||||
Diff against target: |
507 lines (+151/-38) 17 files modified
bzrlib/controldir.py (+18/-0) bzrlib/remote.py (+2/-1) bzrlib/tests/blackbox/test_upgrade.py (+2/-2) bzrlib/tests/per_controldir/test_controldir.py (+37/-1) bzrlib/tests/per_transport.py (+16/-1) bzrlib/tests/stub_sftp.py (+1/-1) bzrlib/tests/test_ftp_transport.py (+7/-4) bzrlib/tests/test_smart_transport.py (+1/-1) bzrlib/tests/test_transport.py (+10/-1) bzrlib/tests/test_urlutils.py (+21/-4) bzrlib/tests/transport_util.py (+1/-6) bzrlib/transport/__init__.py (+9/-7) bzrlib/transport/decorator.py (+9/-0) bzrlib/transport/http/__init__.py (+9/-9) bzrlib/transport/local.py (+2/-0) bzrlib/urlutils.py (+2/-0) doc/en/release-notes/bzr-2.5.txt (+4/-0) |
||||
To merge this branch: | bzr merge lp://staging/~jelmer/bzr/transport-segments | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Riddell (community) | Approve | ||
Review via email: mp+71583@code.staging.launchpad.net |
This proposal supersedes a proposal from 2011-08-15.
Commit message
Allow specifying the colocated branch to use in the branch URL, and retrieving the branch name using ControlDir.
Description of the change
Allow specifying the colocated branch to use in the branch URL, and retrieving the branch name using ControlDir.
* Strip off path segment parameters when converting a URL to a path
* Add ControlDir.
* Add Transport.
* Use URL.__str__ rather than _unsplit_url in a couple of places
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 8/15/2011 6:46 PM, Jelmer Vernooij wrote: /bugs.launchpad .net/bzr/ +bug/380871 /code.launchpad .net/~jelmer/ bzr/transport- segments/ +merge/ 71583 _get_selected_ branch. _get_selected_ branch * Add get_segment_ parameters * Use URL.__str__ rather than
> Jelmer Vernooij has proposed merging
> lp:~jelmer/bzr/transport-segments into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #380871 in
> Bazaar: "support for colocated branches"
> https:/
>
> For more details, see:
> https:/
>
> Allow specifying the colocated branch to use in the branch URL, and
> retrieving the branch name using ControlDir.
>
> * Strip off path segment parameters when converting a URL to a path *
> Add ControlDir.
> Transport.
> _unsplit_url in a couple of places
>
=== modified file 'bzrlib/ tests/blackbox/ test_upgrade. py' tests/blackbox/ test_upgrade. py 2011-04-05 14:47:30 +0000 tests/blackbox/ test_upgrade. py 2011-08-15 16:46:28 +0000 transport( ) bzr(['upgrade' , '--format=2a', url]) bzr.%7E1% 7E'
self. assertEqualDiff ("""Upgrading branch %s ...
self. assertEqual( '', err)
- --- bzrlib/
+++ bzrlib/
@@ -254,7 +254,7 @@
t = self.get_
url = t.base
out, err = self.run_
- - backup_dir = 'backup.bzr.~1~'
+ backup_dir = 'backup.
starting upgrade of %s
making backup of %s.bzr
@@ -262,7 +262,7 @@
starting repository conversion
repository converted
finished
- -""" % (url, url, url, url,backup_dir), out)
+""" % (url, url, url, url, backup_dir), out)
^- Is it possible to not change this? We are informing users where the bzr.%7E1% 7E".
old content is going, and nobody is going to parse "backup.
It is fine if we use URL escaped forms internally, but we should be
trying pretty hard to use the form people are going to understand when
writing messages.
# Base should not keep track of the password ls(t.base, 'http://<email address hidden> :2222/path/ ') ls(t.base, ro%62ey@ ex%41mple. com:2222/ path/')
- - self.assertEqua
+ self.assertEqua
'http://
^- This seems odd. Given that it was a 'b', I don't see how that would
get escaped into %62. (Maybe it was originally escaped, and now that
form is just being preserved. The diff isn't very clear.)
I don't want to block on .~1~, but I do think it is something we should
be pretty careful about. Presenting escaped URLs to users is pretty high
on the "bad UI" list.
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
KbIEACgkQJdeBCY SNAAMoGgCgu/ FevwMJ0tU+ EjaJ7fJMV/ sF K10gUxeRPv0oBU2 d4Xw6
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk5
dZ8An1dQnTw+
=124N
-----END PGP SIGNATURE-----