bzr Upload plugin

Merge lp://staging/~jelmer/bzr-upload/lazy into lp://staging/bzr-upload

  1. lazy
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 79
Merged at revision: 80
Proposed branch: lp://staging/~jelmer/bzr-upload/lazy
Merge into: lp://staging/bzr-upload
Diff against target: 1387 lines (+661/-582)
4 files modified
__init__.py (+20/-562)
cmds.py (+619/-0)
tests/test_auto_upload_hook.py (+11/-7)
tests/test_upload.py (+11/-13)
To merge this branch: bzr merge lp://staging/~jelmer/bzr-upload/lazy
Reviewer Review Type Date Requested Status
Vincent Ladeuil Approve
Review via email: mp+46430@code.staging.launchpad.net

Description of the change

Lazily load bzr-upload. This moves as much code as possible from bzr-upload's
__init__ to cmds.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

Hmm, I thought everything was already lazy loaded, but this makes it more obvious that we still need to load bzrlib.branch to install the hook.

I'll merge it.

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

Hmm, looks like you forgot to remove some stuff from cmds.py so the hook is registered twice, I'll fix that.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: