bzr search plugin

Merge lp://staging/~jelmer/bzr-search/lazier into lp://staging/bzr-search

  1. lazier
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Rejected
Rejected by: Jelmer Vernooij
Proposed branch: lp://staging/~jelmer/bzr-search/lazier
Merge into: lp://staging/bzr-search
Diff against target: 431 lines (+75/-65)
7 files modified
__init__.py (+3/-1)
commands.py (+2/-0)
errors.py (+2/-0)
index.py (+62/-61)
inventory.py (+2/-2)
remote.py (+2/-1)
transport.py (+2/-0)
To merge this branch: bzr merge lp://staging/~jelmer/bzr-search/lazier
Reviewer Review Type Date Requested Status
Bazaar Developers Pending
Review via email: mp+86168@code.staging.launchpad.net

Description of the change

Use more lazy loading:

 * use lazy_regex rather than manual function for ensuring regexes are loaded
 * use lazy_import in index.py - this module gets imported from __init__, so
   every module loaded here will be loaded every time bzr is run
 * use the absolute_import feature, as bzr-search only uses absolute
   imports anyway.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

FWIW This reduces my total "bzr rocks" run time by 4%. It's not a huge improvement, but still worthwile.

Unmerged revisions

94. By Jelmer Vernooij

More lazy importing.

93. By Jelmer Vernooij

Use the absolute_import feature where possible, use lazy regex compilation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: