Merge lp://staging/~jelmer/bzr-gtk/vertical-layout into lp://staging/bzr-gtk/gtk2

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 719
Merged at revision: 731
Proposed branch: lp://staging/~jelmer/bzr-gtk/vertical-layout
Merge into: lp://staging/bzr-gtk/gtk2
Diff against target: 301 lines (+90/-33)
3 files modified
NEWS (+5/-0)
branchview/treeview.py (+14/-5)
viz/branchwin.py (+71/-28)
To merge this branch: bzr merge lp://staging/~jelmer/bzr-gtk/vertical-layout
Reviewer Review Type Date Requested Status
John A Meinel Pending
Review via email: mp+57801@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-02-19.

Description of the change

Patch from Ximin Luo to allow using bzr viz in "widescreen mode" where the revision details are shown next to the graph.

https://bugs.launchpad.net/bzr-gtk/+bug/649273/+attachment/1645811/+files/bzr-gtk_vertical.png

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote : Posted in a previous version of this proposal

seems fine to me. I'm not 100% sure what to look for (other than noticing that there aren't any tests :).

When I tried this, setting the side-by-side layout did move the objects. However it caused it to stop updating the Revision text when selecting a revision. So i'm pretty sure there is a bug somewhere, where moving the items is causing it to lose linkage to the contents.

review: Needs Fixing
Revision history for this message
Jelmer Vernooij (jelmer) wrote : Posted in a previous version of this proposal

I've reproduced these issues here, they should now be fixed.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This works happily here now so I'm going to merge it; I'd be happy to fix any other issues that come up.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: