Merge lp://staging/~jelmer/bzr-builddeb/quilt-hooks into lp://staging/bzr-builddeb

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 685
Proposed branch: lp://staging/~jelmer/bzr-builddeb/quilt-hooks
Merge into: lp://staging/bzr-builddeb
Prerequisite: lp://staging/~jelmer/bzr-builddeb/quilt
Diff against target: 198 lines (+119/-8)
5 files modified
__init__.py (+54/-2)
debian/changelog (+2/-0)
errors.py (+12/-0)
merge_quilt.py (+29/-6)
tests/test_merge_quilt.py (+22/-0)
To merge this branch: bzr merge lp://staging/~jelmer/bzr-builddeb/quilt-hooks
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+87290@code.staging.launchpad.net

Description of the change

Add hooks for merge to unapply patches before merging.

This means that if there are conflicting patches that are being merged, only the patch files will end up with conflicts - the working tree is kept clean.

To post a comment you must log in.
680. By Jelmer Vernooij

Automatically unapply patches before merge operations.
LP: #815854

Revision history for this message
James Westby (james-w) wrote :

Woop, thanks a lot for this one!

10 + if getattr(merger, "_no_quilt_unapplying", False):

Is that to avoid recursion?

This looks good. I'm interested to know how well it works :-)

Thanks,

James

Revision history for this message
James Westby (james-w) :
review: Approve
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> Woop, thanks a lot for this one!
>
> 10 + if getattr(merger, "_no_quilt_unapplying", False):
>
> Is that to avoid recursion?
Yep. I found out the hard way :)

> This looks good. I'm interested to know how well it works :-)
Thanks, me too.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches