bzr-builddeb

Merge lp://staging/~jelmer/bzr-builddeb/712180-zipfile-python2.6 into lp://staging/bzr-builddeb

  1. 712180-zipfile-python2.6
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Rejected
Rejected by: James Westby
Proposed branch: lp://staging/~jelmer/bzr-builddeb/712180-zipfile-python2.6
Merge into: lp://staging/bzr-builddeb
Diff against target: 23 lines (+6/-0)
1 file modified
tests/test_upstream.py (+6/-0)
To merge this branch: bzr merge lp://staging/~jelmer/bzr-builddeb/712180-zipfile-python2.6
Reviewer Review Type Date Requested Status
Vincent Ladeuil Disapprove
Bzr-builddeb-hackers Pending
Review via email: mp+48445@code.staging.launchpad.net

Description of the change

Fix zipfile tests on Python2.6. It doesn't like empty files, so add one.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

https://code.launchpad.net/~vila/bzr-builddeb/test-failures/+merge/48484 use a simpler version

I checked zipfile.writestr for python2.[456], three different versions all accepting the simpler one proposed above but varying slightly implementing yours.

As said on IRC, I'll steal the bug ;)

review: Disapprove

Unmerged revisions

508. By Jelmer Vernooij

Fix the use of zipfile in tests on python2.6.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches