Merge lp://staging/~jelmer/brz/smart-1 into lp://staging/brz
Proposed by
Jelmer Vernooij
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~jelmer/brz/smart-1 |
Merge into: | lp://staging/brz |
Diff against target: |
294 lines (+46/-57) 4 files modified
breezy/bzr/smart/client.py (+5/-7) breezy/bzr/smart/medium.py (+7/-4) breezy/bzr/smart/protocol.py (+22/-26) breezy/bzr/tests/test_smart_transport.py (+12/-20) |
To merge this branch: | bzr merge lp://staging/~jelmer/brz/smart-1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij | Approve | ||
Review via email: mp+444064@code.staging.launchpad.net |
Commit message
Some refactoring ahead of smart protocol changes
Description of the change
Some refactoring ahead of smart protocol changes
To post a comment you must log in.
Unmerged revisions
- 7831. By Jelmer Vernooij
-
Fix typing
- 7830. By Jelmer Vernooij
-
Some refactoring ahead of smart protocol changes
The attempt to merge lp:~jelmer/brz/smart-1 into lp:brz failed. Command exited with 2.
Below is the output from the failed tests.
... OUTPUT TRIMMED ...
Fresh gettext-sys v0.21.3 normalization v0.1.22 branch. cylrog6i/ crates/ osutils) :TimeZone: :timestamp` : use `timestamp_opt()` instead osutils/ src/time. rs:7:43 timestamp, 0).with_ timezone( &Local) ; deprecated) ]` on by default
Fresh unicode-
Fresh memoffset v0.8.0
Fresh parking_lot v0.12.1
Fresh log v0.4.17
Fresh rand v0.8.5
Fresh dirs v5.0.1
Fresh locale_config v0.3.0
Fresh num_cpus v1.15.0
Fresh encoding_rs v0.8.32
Fresh path-clean v1.0.1
Fresh unindent v0.1.11
Fresh indoc v1.0.9
Fresh whoami v1.4.0
Fresh gettext-rs v0.7.0
Fresh breezy-osutils v3.3.3 (/tmp/tarmac/
warning: use of deprecated associated function `chrono:
--> crates/
|
7 | let local_time: DateTime<Local> = Utc.timestamp(
| ^^^^^^^^^
|
= note: `#[warn(
warning: use of deprecated associated function `chrono: :TimeZone: :timestamp` : use `timestamp_opt()` instead osutils/ src/time. rs:8:39 timestamp, 0);
--> crates/
|
8 | let utc_time: DateTime<Utc> = Utc.timestamp(
| ^^^^^^^^^
warning: use of deprecated associated function `chrono: :TimeZone: :timestamp` : use `timestamp_opt()` instead osutils/ src/time. rs:117: 18
--> crates/
|
117 | let dt = Utc.timestamp(t + offset, 0);
| ^^^^^^^^^
warning: use of deprecated associated function `chrono: :NaiveDateTime: :from_timestamp `: use `from_timestamp _opt()` instead osutils/ src/time. rs:133: 47 :from_utc( NaiveDateTime: :from_timestamp (t, 0), Utc),
--> crates/
|
133 | DateTime:
| ^^^^^^^^^^^^^^
warning: use of deprecated associated function `chrono: :NaiveDateTime: :from_timestamp `: use `from_timestamp _opt()` instead osutils/ src/time. rs:151: 51 :from_utc( NaiveDateTime: :from_timestamp (t + offset, 0), Utc),
--> crates/
|
151 | DateTime:
| ^^^^^^^^^^^^^^
warning: use of deprecated associated function `chrono: :TimeZone: :timestamp` : use `timestamp_opt()` instead osutils/ src/time. rs:156: 31
--> crates/
|
156 | let local = Local.timestamp(t, 0);
| ^^^^^^^^^
warning: use of deprecated associated function `chrono: :TimeZone: :timestamp` : use `timestamp_opt()` instead osutils/ src/time. rs:245: 27
--> crates/
|
245 | let system_time = Utc.timestamp(when as i64, 0);
| ^^^^^^^^^
warning: unused import: `std::io::Write` osutils/ src/lib. rs:5:5 unused_ imports) ]` on by default
--> crates/
|
5 | use std::io::Write;
| ^^^^^^^^^^^^^^
|
= note: `#[warn(
warning: `breezy-osutils` (lib) generated 8 warnings cargo/registry/ src/github. com-1ecc6299db9 ec823/pyo3- build-config- 0.18.3/ src/lib. rs --error-format=json --json= diagnostic- rendered- ansi,artifacts, future- incompat --crate-type l...
Running `rustc --crate-name pyo3_build_config --edition=2018 /root/.