Breezy

breezy/help_topics/en/authentication.txt (+3/-3)
breezy/lockdir.py (+0/-3)
breezy/plugins/git/tests/test_dir.py (+1/-1)
breezy/plugins/upload/__init__.py (+1/-1)
breezy/plugins/upload/tests/test_upload.py (+1/-25)
breezy/tests/__init__.py (+0/-6)
breezy/tests/blackbox/test_help.py (+0/-2)
breezy/tests/ftp_server/__init__.py (+0/-82)
breezy/tests/ftp_server/pyftpdlib_based.py (+0/-223)
breezy/tests/test_ftp_transport.py (+0/-151)
breezy/tests/test_http.py (+2/-2)
breezy/tests/test_smart_transport.py (+1/-1)
breezy/tests/transport_util.py (+8/-19)
breezy/transport/__init__.py (+0/-23)
breezy/transport/ftp/__init__.py (+0/-638)
breezy/transport/ftp/_gssapi.py (+0/-128)

To merge this branch:

bzr merge lp://staging/~jelmer/brz/no-more-ftp

Related bugs:

Bug #75422: FTP Transport doesn't implement put_*_non_atomic	Wishlist	Won't Fix
Bug #123719: recommend or autodetect aftp	Wishlist	Won't Fix
Bug #124508: Passive FTP "bzr init" hangs indefinitely	Low	Won't Fix
Bug #127164: need consistent rules for retrying ftp transport operations	Wishlist	Won't Fix
Bug #129307: Unable to branch from http server after ftp push	Low	Won't Fix
Bug #137045: bzr push hangs some minutes if server data quota is exceeded	Wishlist	Won't Fix
Bug #260131: FTP stat() does not return valid permission bits	Wishlist	Won't Fix
Bug #281325: upgrade fails over ftp	Low	Won't Fix
Bug #304848: "Unrecognised container format" after push to FTP server with broken APPE	Low	Won't Fix
Bug #326543: FTPTransport.stat sees mode 000	Low	Won't Fix
Bug #365160: error on ftp servers that allow only one connection per client ip	Wishlist	Won't Fix
Bug #402168: traceback and poor error message for "network unreachable" in ftp	Low	Won't Fix
Bug #404047: bzr update takes ages over FTP	Low	Won't Fix
Bug #408695: should have a configuration item to control active vs passive ftp	Low	Won't Fix
Bug #409615: bzr shouldn't use ftp append when writing a whole file in one go	Low	Won't Fix
Bug #412244: add workaround for Windows/IIS6 FTP server strangeness causing unlock failures.	Undecided	Won't Fix
Bug #412923: ftp put failes on TwoFTP	Low	Won't Fix
Bug #422230: MemoryError: out of memory - using bzr branch ftp://	Low	Won't Fix
Bug #598646: can't commit over ftp: error_temp: 451 Rename/move failure: File exists	Low	Won't Fix
Bug #622566: ftp access inefficiency	Low	Won't Fix
Bug #662042: EOFError traceback when ftp server refuses connection	Low	Won't Fix
Bug #927929: Ftp servers with bogus APPE are not supported	Wishlist	Won't Fix
Bug #1698469: ftp tests fail	Medium	Won't Fix

Link a bug report

Reviewer	Date Requested	Status
Vincent Ladeuil		Approve on 2018-05-11
Martin Packman	2018-04-02	Approve on 2018-05-09
Review via email: mp+342526@code.staging.launchpad.net

Commit message

Drop support for FTP.

Description of the change

Drop support for FTP.

* Our testing situation for FTP isn't great
* FTP is not as commonly used anymore as when Bazaar was started
* Breezy operations over FTP are slower than over other transports, so we
should steer users away from it
* FTP isn't well defined in some areas, resulting in lots of annoying corner case bugs
* FTP connections are almost always insecure

Revision history for this message

Martin Packman (gz) wrote on 2018-05-09:

I'm a little sad about this (my first patch to bzr was fixing some dumb ftp thing), but I agree with your reasoning. Along with ftp being discouraged as a whole (see also https://lwn.net/Articles/720856/ for instance), removing support altogether seems correct.

review: Approve

Revision history for this message

The Breezy Bot (the-breezy-bot) wrote on 2018-05-11:

Merging failed
https://ci.breezy-vcs.org/job/brz-dev/151/