Merge lp://staging/~jelmer/brz/http-header-overrides into lp://staging/brz
Proposed by
Jelmer Vernooij
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Jelmer Vernooij | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merge reported by: | The Breezy Bot | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~jelmer/brz/http-header-overrides | ||||
| Merge into: | lp://staging/brz | ||||
| Diff against target: |
50 lines (+8/-4) 3 files modified
breezy/plugins/launchpad/lp_registration.py (+2/-3) breezy/transport/http/_urllib2_wrappers.py (+3/-1) doc/en/release-notes/brz-3.0.txt (+3/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~jelmer/brz/http-header-overrides | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij | Approve | ||
| Martin Packman | Approve | ||
|
Review via email:
|
|||
Commit message
Only set default HTTP headers if they weren't provided by the caller.
Description of the change
Only set default HTTP headers if they weren't provided by the caller.
Any suggetions on how to properly test this?
To post a comment you must log in.
Revision history for this message
| Vincent Ladeuil (vila) wrote | # |
Revision history for this message
| The Breezy Bot (the-breezy-bot) wrote | # |
Revision history for this message
| Jelmer Vernooij (jelmer) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
> Any suggestions on how to properly test this?
Setting up a dedicated http server to check which headers (or even only the ones the test cares about) are received seems to be the most appropriate.