Merge lp://staging/~jelmer/brz/gpg-detached-sign into lp://staging/brz

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp://staging/~jelmer/brz/gpg-detached-sign
Merge into: lp://staging/brz
Diff against target: 448 lines (+73/-111)
8 files modified
breezy/bzr/ (+5/-3)
breezy/ (+39/-31)
breezy/ (+1/-1)
breezy/ (+6/-5)
breezy/tests/per_repository/ (+1/-1)
breezy/tests/ (+2/-1)
breezy/tests/ (+13/-54)
breezy/tests/ (+6/-15)
To merge this branch: bzr merge lp://staging/~jelmer/brz/gpg-detached-sign
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email:

Commit message

Add support for passing mode argument to GPGSignature.sign.

Description of the change

Add support for passing mode argument to GPGSignature.sign.

This is necessary for brz-git, which needs to create detached signatures.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Thanks, so questions answered, constants are the same as the mapping, but the breezy interface doesn't depend on gpg module being installed. Also, argument not defaulted as bzr wants clear but git needs detached, so better to just pass.

review: Approve
Revision history for this message
The Breezy Bot (the-breezy-bot) wrote :

Running landing tests failed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches