Merge lp://staging/~jelmer/brz/git-http-username into lp://staging/brz

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp://staging/~jelmer/brz/git-http-username
Merge into: lp://staging/brz
Diff against target: 39 lines (+12/-3)
2 files modified
breezy/git/ (+8/-1)
breezy/git/ (+4/-2)
To merge this branch: bzr merge lp://staging/~jelmer/brz/git-http-username
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email:

Description of the change

Strip username from URLs before passing them to httplib.

This fixes access to Git HTTP repositories with authentication, such as bitbucket.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Thanks! Should have a test that passes in a username.

review: Approve
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks. There is a long outstanding bug report about testing git over HTTP.

On 14 February 2019 11:53:08 GMT, Martin Packman <email address hidden> wrote:
>Review: Approve
>Thanks! Should have a test that passes in a username.
>You are the owner of lp:~jelmer/brz/git-http-username.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches