Merge lp://staging/~jelmer/brz/bad-bug-url into lp://staging/brz
Proposed by
Jelmer Vernooij
| Status: | Merged |
|---|---|
| Approved by: | Jelmer Vernooij |
| Approved revision: | no longer in the source branch. |
| Merge reported by: | The Breezy Bot |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~jelmer/brz/bad-bug-url |
| Merge into: | lp://staging/brz |
| Diff against target: |
266 lines (+135/-33) 5 files modified
breezy/bugtracker.py (+30/-1) breezy/log.py (+20/-15) breezy/revision.py (+2/-9) breezy/tests/test_bugtracker.py (+33/-0) breezy/tests/test_log.py (+50/-8) |
| To merge this branch: | bzr merge lp://staging/~jelmer/brz/bad-bug-url |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Packman | Approve | ||
|
Review via email:
|
|||
Description of the change
Improve handling of bad bug urls:
* Raise an exception when invalid bug URLs are specified to 'brz commit'
* Print exceptions when customer log handlers raise an exception
rather than aborting altogether.
To post a comment you must log in.
Revision history for this message
| The Breezy Bot (the-breezy-bot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks reasonable, see two inline comments. Also, decoded bug urls should probably be defined as either url-escaped ascii or cleanly decoded to unicode, but that can change later.