Breezy

Merge lp://staging/~jelmer/brz/backslash-support into lp://staging/brz

  1. backslash-support
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp://staging/~jelmer/brz/backslash-support
Merge into: lp://staging/brz
Diff against target: 111 lines (+50/-6)
5 files modified
breezy/osutils.py (+11/-5)
breezy/tests/blackbox/test_add.py (+13/-0)
breezy/tests/blackbox/test_remove.py (+13/-0)
breezy/tests/test_osutils.py (+4/-1)
doc/en/release-notes/brz-3.0.txt (+9/-0)
To merge this branch: bzr merge lp://staging/~jelmer/brz/backslash-support
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email: mp+355135@code.staging.launchpad.net

Commit message

Support adding files with filenames that are just a backslash on
platforms where it is not the path separator.

Description of the change

Support adding files with filenames that are just a backslash on
platforms where it is not the path separator.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Okay, this still terrifies me, but I guess all we're really doing is giving *nix users one more in a long list of footguns.

Revision history for this message
The Breezy Bot (the-breezy-bot) wrote :

Voting criteria not met
https://ci.breezy-vcs.org/job/land-brz/504/

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I think the main consequence of this is that it's possible to create branches that can not be checked out on Windows. However, this is already possible - there is a separate bug open about warning in cases like this: bug 1743186

Revision history for this message
Martin Packman (gz) wrote :

Okay, lets do it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches