Breezy

Merge lp://staging/~jelmer/brz/authconfperm into lp://staging/brz

  1. authconfperm
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp://staging/~jelmer/brz/authconfperm
Merge into: lp://staging/brz
Diff against target: 144 lines (+64/-3)
4 files modified
breezy/config.py (+21/-1)
breezy/help_topics/en/configuration.txt (+4/-0)
breezy/tests/test_config.py (+34/-2)
doc/en/release-notes/brz-3.0.txt (+5/-0)
To merge this branch: bzr merge lp://staging/~jelmer/brz/authconfperm
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email: mp+325541@code.staging.launchpad.net

Commit message

Use tight permissions on authentication.conf.

Description of the change

When creating authentication.conf, make sure only the user can read it.

When opening an existing authentication.conf, warn if others can read the file - allow this warning to be suppressed by setting ``suppress_warnings=insecure_permissions``.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

General concept seems fine, though we still don't really want users putting passwords in there. Have some nits about the implementation inline.

Yet another change that makes me want to get to saner trace/warnings soon.

review: Approve
Revision history for this message
The Breezy Bot (the-breezy-bot) wrote :

Running landing tests failed
http://10.242.247.184:8080/job/brz-dev/129/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches