OpenVista/GT.M Integration

Merge lp://staging/~jeff-apple/openvista-gtm-integration/bug359418 into lp://staging/openvista-gtm-integration

  1. bug359418
  2. Merge into mainline
Proposed by jeff.apple
Status: Merged
Merged at revision: not available
Proposed branch: lp://staging/~jeff-apple/openvista-gtm-integration/bug359418
Merge into: lp://staging/openvista-gtm-integration
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~jeff-apple/openvista-gtm-integration/bug359418
Reviewer Review Type Date Requested Status
Jon Tai Approve
Review via email: mp+5457@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jon Tai (jontai) wrote :

Changes look good to me - have we tested this on Cache to ensure that it still works there?

review: Approve
Revision history for this message
jeff.apple (jeff-apple) wrote :

> Changes look good to me - have we tested this on Cache to ensure that it still
> works there?

Do we have a Cache instance that we can destabilize?

Revision history for this message
Jon Tai (jontai) wrote :

> Do we have a Cache instance that we can destabilize?

I can't think of one off-hand, no. Maybe we just merge it now, (possibly pending Joel's review), then worry about regression testing this stuff all at once at the end of Phase I. I've e-mailed Karthick (you should have been CC'd) to make sure this stuff gets regression tested on Cache on both Windows and Linux.

Revision history for this message
jeff.apple (jeff-apple) wrote :

> > Do we have a Cache instance that we can destabilize?
>
> I can't think of one off-hand, no. Maybe we just merge it now, (possibly
> pending Joel's review), then worry about regression testing this stuff all at
> once at the end of Phase I. I've e-mailed Karthick (you should have been
> CC'd) to make sure this stuff gets regression tested on Cache on both Windows
> and Linux.

Maybe sql.medsphere.com could be used. I'm not sure what all that's doing these days.

lp://staging/~jeff-apple/openvista-gtm-integration/bug359418 updated
8. By jeff.apple

Comments added

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mumps/HLCSLNCH.m'
2--- mumps/HLCSLNCH.m 2009-04-11 03:29:54 +0000
3+++ mumps/HLCSLNCH.m 2009-04-11 03:35:29 +0000
4@@ -39,7 +39,7 @@
5 ;-- execute environment check routine if HLQUIT is defined then terminate
6 I HLENV'="" X HLENV G:$D(HLQUIT) STARTQ
7 ;Multi-Servers, only enable the link if not OpenM
8- I $P(HLPARM4,U,3)="M",$S(^%ZOSF("OS")'["OpenM":1,1:$$OS^%ZOSV["VMS") D G STARTQ
9+ I $P(HLPARM4,U,3)="M",$$NOTMULTI D G STARTQ
10 . W !,$C(7),"This LLP is a multi-threaded server. It is controlled by external service, i.e. TCPIP/UCX. You must use the external service to start this LLP."
11 . Q
12 ;
13@@ -97,7 +97,7 @@
14 W !,"like to shutdown.",!
15 S DIC="^HLCS(870,",DIC(0)="QEAMZ" D ^DIC K DIC Q:Y<0
16 S HLDP=+Y,HLDAPP=Y(0,0),HLPARM0=Y(0),HLPARM4=$G(^HLCS(870,HLDP,400))
17- I $P(HLPARM4,U,3)="M",$S(^%ZOSF("OS")'["OpenM":1,1:$$OS^%ZOSV["VMS") D Q
18+ I $P(HLPARM4,U,3)="M",$$NOTMULTI D Q
19 . W !,$C(7),"This LLP is a multi-threaded server. It is controlled by external service, i.e. UCX. You must use the external service to disable this LLP."
20 . Q
21 ;
22@@ -124,4 +124,7 @@
23 W !,"The job for the "_HLDAPP_" Lower Level Protocol will be shut down."
24 Q
25 ;
26+NOTMULTI() ; Returns 1 if implementation can't run multithreaded listener
27+ Q:^%ZOSF("OS")["GT.M" 0
28+ Q $S(^%ZOSF("OS")'["OpenM":1,1:$$OS^%ZOSV["VMS")
29 STOPQ Q
30
31=== modified file 'mumps/HLCSTCP.m'
32--- mumps/HLCSTCP.m 2009-04-11 03:29:54 +0000
33+++ mumps/HLCSTCP.m 2009-04-11 03:35:29 +0000
34@@ -28,8 +28,8 @@
35 . ;couldn't open listener port
36 . I HLCSFAIL D EXITS("Openfail") Q
37 ;
38- ;multi-threaded listener (OpenM)
39- I $G(HLTCPCS)="M",^%ZOSF("OS")["OpenM" D Q
40+ ;multi-threaded listener (OpenM or GT.M)
41+ I $G(HLTCPCS)="M",(^%ZOSF("OS")["OpenM")!(^%ZOSF("OS")["GT.M") D Q
42 . D ST1,MON("Listen"),LISTEN^%ZISTCPS(HLTCPORT,"SERVERS^HLCSTCP("""_HLDP_""")")
43 Q
44 ;
45@@ -67,7 +67,7 @@
46 I $G(%)="" D ^%ZTER Q
47 S (IO,IO(0))="SYS$NET",HLDP=$P(%,"^",2)
48 ; **VMS specific code, need to share device**
49- O IO:(TCPDEV):60 E D MON("Openfail") Q
50+ X "O IO:(TCPDEV):60" E D MON("Openfail") Q
51 LISTEN ;
52 N HLLSTN,HLCSOUT,HLDBACK,HLDBSIZE,HLDREAD,HLDRETR,HLRETRA,HLDWAIT,HLOS,HLTCPADD,HLTCPCS,HLTCPLNK,HLTCPORT,HLTCPRET,HLCSFAIL
53 I '$$INIT D ^%ZTER Q

Subscribers

People subscribed via source and target branches