Purchase - Workflow and Organization

Merge lp://staging/~jean-lelievre/purchase-wkfl/new_modules_purchase into lp://staging/~purchase-core-editors/purchase-wkfl/7.0

  1. new_modules_purchase
  2. Merge into 7.0
Proposed by Jean LELIEVRE ElicoCorp
Status: Rejected
Rejected by: Yannick Vaucher @ Camptocamp
Proposed branch: lp://staging/~jean-lelievre/purchase-wkfl/new_modules_purchase
Merge into: lp://staging/~purchase-core-editors/purchase-wkfl/7.0
Diff against target: 1618 lines (+1475/-0)
24 files modified
product_supplier_info/__init__.py (+23/-0)
product_supplier_info/__openerp__.py (+47/-0)
product_supplier_info/product.py (+54/-0)
product_supplier_info/product_view.xml (+71/-0)
purchase_contacts/__init__.py (+25/-0)
purchase_contacts/__openerp__.py (+51/-0)
purchase_contacts/i18n/zh_CN.po (+42/-0)
purchase_contacts/purchase.py (+90/-0)
purchase_contacts/purchase_view.xml (+54/-0)
purchase_control_supplier/__init__.py (+25/-0)
purchase_control_supplier/__openerp__.py (+46/-0)
purchase_control_supplier/i18n/zh_CN.po (+37/-0)
purchase_control_supplier/purchase.py (+53/-0)
purchase_control_supplier/purchase_view.xml (+34/-0)
purchase_po_price/__init__.py (+23/-0)
purchase_po_price/__openerp__.py (+42/-0)
purchase_po_price/i18n/zh_CN.po (+89/-0)
purchase_po_price/purchase.py (+113/-0)
purchase_po_price/purchase_view.xml (+68/-0)
purchase_price_list_item/__init__.py (+23/-0)
purchase_price_list_item/__openerp__.py (+52/-0)
purchase_price_list_item/i18n/purchase_price_list_item.po (+33/-0)
purchase_price_list_item/purchase.py (+332/-0)
purchase_price_list_item/purchase_view.xml (+48/-0)
To merge this branch: bzr merge lp://staging/~jean-lelievre/purchase-wkfl/new_modules_purchase
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Needs Resubmitting
Yannick Vaucher @ Camptocamp one mp per module Needs Resubmitting
Stefan Rijnhart (Opener) Needs Information
Review via email: mp+180463@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-08-12.

Description of the change

Add modules :
- purchase_contacts : Add contact person and delivery person in purchase
- purchase_control_supplier : Enables/Disables the supplier control in Purchase
- purchase_po_price : Enable/Disable control on PO Price
- purchase_price_list_item : Improve purchase price managment ( In Purchase List Item, the price is fixed based on price_surchage if base is 'fixed on UOP' ; If 'fixed on UOP', if product UOP change, the price list price will be change automtically ; Add field 'Qty on Hand', and 'Stock Values' for product ; Add field 'Qty on Hand', 'Stock Values', UOP in product list view )
- product_supplier_info : Add a specific View for Supplier

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Jean,

thank you for your contributions. It would be helpful for the reviewers if you could create separate proposals for each of the added modules. It will make review easier and speed up the reviewing process. Would it be acceptable to resubmit your modules in separate proposals?

review: Needs Information
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Any update ?

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi Jean, I didn't checked if you have been able to create separate proposals for each module, if yes, can you close this MP?

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Hello Jean,

Please resubmit all modules separately. It will be better to have one MP per module

Thanks

review: Needs Resubmitting (one mp per module)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

This project is now hosted on https://github.com/OCA/purchase-workflow. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

17. By Jean LELIEVRE ElicoCorp

[ADD] purchase_control_supplier, purchase_po_price, purchase_price_list_item

16. By Jean LELIEVRE ElicoCorp

Add contact person and delivery person in Purchase

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches