Merge into trunk : ubuntu-download-manager-lp1296415 : Code : ubuntu-download-manager

Status:

Rejected

Rejected by:

Jamie Strandboge on 2014-07-17

Proposed branch:

lp://staging/~jdstrand/ubuntu-download-manager/ubuntu-download-manager-lp1296415

Merge into:

lp://staging/ubuntu-download-manager

Diff against target:

64 lines (+24/-1)

5 files modified

debian/control (+2/-1)
debian/rules (+4/-0)
debian/ubuntu-download-manager.dirs (+1/-0)
debian/ubuntu-download-manager.install (+1/-0)
debian/usr.bin.ubuntu-download-manager (+16/-0)

To merge this branch:

bzr merge lp://staging/~jdstrand/ubuntu-download-manager/ubuntu-download-manager-lp1296415

Wishlist

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Manuel de la Peña (community)		2014-06-24	Needs Fixing on 2014-07-15
PS Jenkins bot	continuous-integration		Approve on 2014-06-25
Review via email: mp+224367@code.staging.launchpad.net

Commit message

  * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
    - add debian/usr.bin.ubuntu-download-manager
    - debian/control: Build-Depends on dh-apparmor
    - debian/rules: update override_dh_installdeb to use dh_apparmor
    - debian/ubuntu-download-manager.dirs: add etc/apparmor.d
    - debian/ubuntu-download-manager.install: install profile in to place

Description of the change

  * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
    - add debian/usr.bin.ubuntu-download-manager
    - debian/control: Build-Depends on dh-apparmor
    - debian/rules: update override_dh_installdeb to use dh_apparmor
    - debian/ubuntu-download-manager.dirs: add etc/apparmor.d
    - debian/ubuntu-download-manager.install: install profile in to place

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-24:

#

PASSED: Continuous integration, rev:303
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/678/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-utopic-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-utopic-armhf-ci/37
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-utopic-armhf-ci/37/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/678/rebuild

review: Approve (continuous-integration)

lp://staging/~jdstrand/ubuntu-download-manager/ubuntu-download-manager-lp1296415 updated on 2014-06-24

304. By Jamie Strandboge on 2014-06-24: debian/usr.bin.ubuntu-download-manager: more closely mimic unconfined with
exec transitions

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-25:

#

PASSED: Continuous integration, rev:304
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/679/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-utopic-amd64-ci/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-utopic-armhf-ci/38
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-utopic-armhf-ci/38/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/679/rebuild

review: Approve (continuous-integration)

Revision history for this message

Manuel de la Peña (mandel) wrote on 2014-07-15:

#

The projects has two diff binaries that need the same rights, can you please update the MP so that ubuntu-upload-manager security is correctly set?

PS: Sorry for the late review.

review: Needs Fixing

Revision history for this message

Jamie Strandboge (jdstrand) wrote on 2014-07-17:

#

Rejecting for now since we won't be implementing this (see bug description).

Unmerged revisions

304. By Jamie Strandboge on 2014-06-24: debian/usr.bin.ubuntu-download-manager: more closely mimic unconfined with
exec transitions
303. By Jamie Strandboge on 2014-06-24: * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
   - add debian/usr.bin.ubuntu-download-manager
   - debian/control: Build-Depends on dh-apparmor
   - debian/rules: update override_dh_installdeb to use dh_apparmor
   - debian/ubuntu-download-manager.dirs: add etc/apparmor.d
   - debian/ubuntu-download-manager.install: install profile in to place

ubuntu-download-manager

Merge lp://staging/~jdstrand/ubuntu-download-manager/ubuntu-download-manager-lp1296415 into lp://staging/ubuntu-download-manager

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers