Mir

Merge lp://staging/~jdstrand/mir/snappy-packaging.framework-policy-for-qml-apps into lp://staging/~mir-team/mir/snappy-packaging

  1. snappy-packaging.framework-policy-for-qml-apps
  2. Merge into snappy-packaging
Proposed by Alberto Aguirre
Status: Merged
Approved by: kevin gunn
Approved revision: 19
Merged at revision: 19
Proposed branch: lp://staging/~jdstrand/mir/snappy-packaging.framework-policy-for-qml-apps
Merge into: lp://staging/~mir-team/mir/snappy-packaging
Diff against target: 40 lines (+15/-6)
2 files modified
overlay/meta/framework-policy/apparmor/policygroups/client (+10/-6)
overlay/meta/framework-policy/seccomp/policygroups/client (+5/-0)
To merge this branch: bzr merge lp://staging/~jdstrand/mir/snappy-packaging.framework-policy-for-qml-apps
Reviewer Review Type Date Requested Status
kevin gunn (community) Approve
Olli Ries Pending
Ted Gould Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+264439@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-07-09.

Commit message

update framework-policy for qml snap issues
add FIXMEs for hardware access in framework-policy

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote : Posted in a previous version of this proposal

Yikes, this has a bunch of extra stuff. Let me clean that out.

Revision history for this message
Jamie Strandboge (jdstrand) wrote : Posted in a previous version of this proposal

Oh wait, no it doesn't. r19 is fine-- the email from LP showed a lot more

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:19
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~jdstrand/mir/snappy-packaging.framework-policy-for-qml-apps/+merge/264359/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/mir-ci/4297/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/3129
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/652
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/3077/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/446/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/3077/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/4297/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

(1) Are you sure you've got the right project? Unity System Compositor does not live in lp:mir ...

119 +services:
120 + - name: system-compositor
121 + description: "system compositor"

(2) overlay/ - Does this replace the existing (and presently unused) snappy/ ?

(3) New files need to go in a directory:

8 === added file 'Makefile'
125 === added file 'server'

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

In fact lp:mir has nothing to do with Unity System Compositor or QML, so it sounds like you're targeting the wrong branch.

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Re-proposed to merge into lp:~mir-team/mir/snappy-packaging which I think was the intended target.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Yes, lp:~mir-team/mir/snappy-packaging is the intended target. Thank you.

Revision history for this message
kevin gunn (kgunn72) :
review: Approve
Revision history for this message
kevin gunn (kgunn72) wrote :

ug, lost my comment. I did test this and the hw access had been previously identified in the upload review. thanks jamie!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches