Merge lp://staging/~jderose/dbase32/py3.5 into lp://staging/dbase32
| Status: | Merged |
|---|---|
| Merged at revision: | 337 |
| Proposed branch: | lp://staging/~jderose/dbase32/py3.5 |
| Merge into: | lp://staging/dbase32 |
| Diff against target: |
226 lines (+70/-50) 4 files modified
dbase32/_dbase32py.py (+13/-6) dbase32/tests/__init__.py (+28/-19) dbase32/tests/test__dbase32py.py (+12/-12) dbase32/tests/test_rfc3548.py (+17/-13) |
| To merge this branch: | bzr merge lp://staging/~jderose/dbase32/py3.5 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Gerard DeRose | Approve | ||
| Chad Miller | Pending | ||
|
Review via email:
|
|||
Description of the change
For full background, please see:
https:/
In short, Python 3.5 changes some details in the exact error message text used in TypeError's raised when dealing with the Python Buffer Protocol. Especially effected (in my experience thus far) are Python C extensions that parse their arguments using "y#", "s#", and similar argument formats.
This merge:
* Adds conditionals to all effected TypeError unit tests so they test against different error message text for Python >= 3.5 vs Python < 3.5
* Adds conditionals to the pure-Python fallback/reference implementation in dbase32._dbase32py so its TypeError messages match those of the dbase32._dbase32 C extension under both Python >= 3.5 and < 3.5 (both implementations are subject to the same unit tests)
Going to do the tacky self approve as new python3-defaults in Wily now supports Python 3.5.