Merge lp://staging/~jcsackett/lp-release-manager-tools/bugs-for-juju-reports into lp://staging/~sinzui/lp-release-manager-tools/trunk

Proposed by j.c.sackett
Status: Merged
Merged at revision: 23
Proposed branch: lp://staging/~jcsackett/lp-release-manager-tools/bugs-for-juju-reports
Merge into: lp://staging/~sinzui/lp-release-manager-tools/trunk
Diff against target: 198 lines (+58/-47)
2 files modified
lp_release_tools/pull_bugs.py (+52/-42)
lp_release_tools/report_branch_contributions.py (+6/-5)
To merge this branch: bzr merge lp://staging/~jcsackett/lp-release-manager-tools/bugs-for-juju-reports
Reviewer Review Type Date Requested Status
Curtis Hovey code Approve
Review via email: mp+206186@code.staging.launchpad.net

Commit message

Breaks up pull_bugs.py so useful functions are importable (e..g by juju-reports)

Description of the change

This branch breaks up the pull_bugs.py functionality into useful functions that can be imported and used in the juju-reports scorecard work. It also contains some drive by fixes in report_branch_contributions.py

pull_bugs.py
============
* Getting launchpad projects via launchpad lib has been broken out into its own function. This takes an lp instance and the project name, so other tools can configure lp as necessary for their needs while pull_bugs continues to create an lp instance suitable for its function.

* Getting bug data has been altered so that it receives a dict of bug search parameters suitable for searchTasks rather than assembling said data from options. The dict is assembled in main() out of the options data.

* options.statuses now defaults to an empty list, and if no data is provided in the command line it uses the default list defined at the top. This fixes a bug wherein desired statuses were appended to the list of all statuses and therefor saw no change in behavior. Now -s Fix Committed will get all bugs that are Fix Committed.

* the service root option has been removed, b/c it wasn't used in the script anywhere.

* various lint fixes have been made.

report_branch_contributions.py
==============================
* Filtering out canonical employees now actually looks at the email address; it was accidentally looking at the unparsed author field before.

* show_branch_contributions takes params now so it can handle the verbose option. It would have failed before.

* various lint fixes.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: