Merge lp://staging/~jcsackett/launchpad/unlink-321675 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | j.c.sackett |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12136 |
| Proposed branch: | lp://staging/~jcsackett/launchpad/unlink-321675 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
38 lines (+4/-4) 2 files modified
lib/lp/bugs/browser/bugbranch.py (+3/-3) lib/lp/bugs/stories/bugs/xx-link-bug-to-branch.txt (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~jcsackett/launchpad/unlink-321675 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=bac][ui=none][bug=321675] Changes the 'Delete' button when unlinking a bug and a branch to "Remove link"
Description of the change
Summary
=======
When a bug is unlinked from a branch, the button to confirm the action is "Delete." This is both confusing and scary for a user, because it's not clear if you're deleting the branch or deleting the link. A first step in fixing this ui is to rename the button to Remove link, which matches the language used in the page.
Implementation
==============
lib/lp/
-------
Update the action name to "Remove link" instead of "Delete"
There are also some drive by lint fixes; changes to wrap length and line spacing.
lib/lp/
-------
Updated to match the new action name.
QA
==
1) Create a link between a bug and a branch on launchpad.dev
2) Remove the link from the bug's page
3) The button should say Remove link, not Delete. Clicking it should remove the link
Lint
====
| Brad Crittenden (bac) | # |
