Merge lp://staging/~jcsackett/launchpad/remove-duplicate-settings into lp://staging/launchpad
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | j.c.sackett | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 12897 | ||||
| Proposed branch: | lp://staging/~jcsackett/launchpad/remove-duplicate-settings | ||||
| Merge into: | lp://staging/launchpad | ||||
| Prerequisite: | lp://staging/~jcsackett/launchpad/add-security-audit-utility | ||||
| Diff against target: |
306 lines (+143/-27) 3 files modified
database/schema/security.cfg (+5/-27) lib/lp/scripts/utilities/tests/test_audit_security_settings.py (+26/-0) utilities/audit-security-settings.py (+112/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~jcsackett/launchpad/remove-duplicate-settings | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[r=allenap][bug=765207] Removes duplicate settings from security.cfg
Description of the change
Summary
=======
Investigating errors occuring in some cronscripts, duplicate security settings were found in database/
A previous branch created a utiility that identified these duplicates. This branch removes the dupes under the advisement that in each case we want to keep the setting that provides the broadest permissions for the cronscripts.
Preimplementation
=================
Spoke with Curtis Hovey about which settings to keep.
Implementation
==============
database/
-------
Removed duplicate settings within each configuration block (e.g. a section beginning with [$SECTION].
Tests
=====
Given the number of things removed, ec2 is the only viable test. This branch has already been submitted.
QA
==
qa-untestable
Lint
====
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
database/
lib/lp/
utilities/
database/
740: Line exceeds 78 characters.
741: Line exceeds 78 characters.
742: Line exceeds 78 characters.
768: Line exceeds 78 characters.
772: Line exceeds 78 characters.
827: Line exceeds 78 characters.
842: Line exceeds 78 characters.
843: Line exceeds 78 characters.
859: Line exceeds 78 characters.
860: Line exceeds 78 characters.
863: Line exceeds 78 characters.
864: Line exceeds 78 characters.
865: Line exceeds 78 characters.
917: Line exceeds 78 characters.
918: Line exceeds 78 characters.
919: Line exceeds 78 characters.
947: Line exceeds 78 characters.
1029: Line exceeds 78 characters.
1039: Line exceeds 78 characters.
1040: Line exceeds 78 characters.
Errors in security.cfg are a result of the cfg format.
| Gavin Panella (allenap) | # |
