Merge lp://staging/~jcsackett/launchpad/fix-bottom-searchfield-684151 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Graham Binns |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12067 |
| Proposed branch: | lp://staging/~jcsackett/launchpad/fix-bottom-searchfield-684151 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
133 lines (+24/-14) 2 files modified
lib/lp/app/browser/tests/launchpad-search-pages.txt (+23/-13) lib/lp/app/templates/launchpad-search-form.pt (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~jcsackett/launchpad/fix-bottom-searchfield-684151 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=gmb][ui=none][bug=684151] Changes name attribute on text input for the secondary launchpad search form to 'text' instead of 'text-secondary', so searches from it work.
Description of the change
Summary
=======
On search result pages from +search, there is a secondary search form below the result set for large results. This second form doesn't work, because it generates a form with the text input element having a name of "text-secondary" as a result of it ape-ing the id, which must be text-secondary to avoid a collision with the primary form at the top of the page.
To fix this, the name should be switched from text-secondary to text.
Implementation
==============
In the template for the form, the section setting the name for the element postfixed it with the suffix -secondary.
Tests
=====
bin/test -t launchpad-
Demo & QA
=========
Go to the search page; enter a search in the secondary form. It should work.
| Graham Binns (gmb) | # |
