Merge lp://staging/~jcsackett/launchpad/bugtasks-deacitvated-context-632847 into lp://staging/launchpad

[r=gmb][bug=632847] Adds check to prevent bugtasks for deactivated products from showing up for people who can't see the product.

Summary
=======

Per bug 632847, bugtasks for deactivated projects can show up in search results. Users clicking on links for these bugtasks then get a 404. The best fix for this is to make sure that users that can't verify the deactivated project (i.e. aren't registry admins) don't see those bugtasks.

Preimplementation
=================

Spoke with Deryck Hodge and Curtis Hovey

Proposed Fix
============

Add a step in the query building for bug search that checks is the searching user is in registry admins; if they're not, filter out bugtasks for deactivated products.

Implementation
==============

lib/lp/bugs/browser/tests/test_buglisting.py
--------------------------------------------
Tests added.

lib/lp/bugs/model/bugtask.py
----------------------------
A check is added to see if the searching user is in registry admins; if they're not, an extra clause is added to the query to remove products that are deactivated.

lib/lp/registry/browser/tests/test_person_view.py
-------------------------------------------------
Drive by clean up of whitespace while trying to decide where to place new tests.

Tests
=====

bin/test -t test_buglisting

Demo & QA
=========

Using the link provided in the bug (though switch to qastaging). If you are signed in and are a member of registry admins, you should see the bugtask reported as problematic in the bugtask. If you are not in registry admins (or logout), you should not see it.

Lint
====

make lint output:

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/browser/tests/test_buglisting.py
  lib/lp/bugs/model/bugtask.py
  lib/lp/registry/browser/tests/test_person_view.py