Launchpad itself

Merge lp://staging/~jcsackett/launchpad/autofocus into lp://staging/launchpad

autofocus
Merge into devel

Proposed by j.c.sackett on 2010-12-20

Status:

Merged

Approved by:

j.c.sackett on 2010-12-21

Approved revision:

no longer in the source branch.

Merged at revision:

12135

Proposed branch:

lp://staging/~jcsackett/launchpad/autofocus

Merge into:

lp://staging/launchpad

Diff against target:

57 lines (+14/-0)

4 files modified

lib/lp/app/templates/root-index.pt (+3/-0)
lib/lp/blueprints/templates/specifications-index.pt (+4/-0)
lib/lp/code/templates/bazaar-index.pt (+4/-0)
lib/lp/registry/templates/projects-index.pt (+3/-0)

To merge this branch:

bzr merge lp://staging/~jcsackett/launchpad/autofocus

Related bugs:

Bug #135009: Search field isn't auto-focused on Blueprints front page	Low	Fix Released
Bug #135012: Search field isn't auto-focused on Code front page	Low	Fix Released
Bug #135015: Search field isn't auto-focused on front page	Low	Fix Released
Bug #135018: Search field isn't auto-focused on Projects page	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Leonard Richardson (community)		2010-12-20	Approve on 2010-12-21
Review via email: mp+44284@code.staging.launchpad.net

Commit message

[r=leonardr][ui=none][bug=135009,135012,135015,135018] Adds autofocus to several fields needing it throughout Launchpad

Description of the change

Summary
=======

A number of search fields should auto focus on page load, and do not. This adds auto focus to those forms/fields.

Preimplemenation Talk
=====================

Spoke with Curtis Hovey about how to set auto focus.

Implementation
==============

lib/lp/app/templates/root-index.pt
lib/lp/registry/templates/projects-index.pt
lib/lp/code/templates/bazaar-index.pt
lib/lp/blueprints/templates/specifications-index.pt
---------------------------------------------------

In each file, added setFocusByName to the template for the form as it has been used elsewhere.

Demo & QA
=========

Open http://blueprints.launchpad.dev/; the search field should get focus
Open http://code.launchpad.dev/; the search field should get focus
Open http://launchpad.dev/projects; the search field should get focus
Open http://launchpad.dev/; the search field should get focus

Revision history for this message

Leonard Richardson (leonardr) wrote on 2010-12-21:

Approved, assuming that the inputs mentioned in setFocusByName will always be present. (As far as I can tell by looking at the code, this is the case.)

review: Approve

Revision history for this message

j.c.sackett (jcsackett) wrote on 2010-12-21:

> Approved, assuming that the inputs mentioned in setFocusByName will always be present.

That is the case; in each case the javascript is loaded after the form loads, and the form is not dynamic in nature.