Merge lp://staging/~jcsackett/charm-tools/libify-proof into lp://staging/~charmers/charm-tools/trunk

Reviewers: mp+143785_code.launchpad.net,

Message:
Please take a look.

Description:
Make charm proof code importable elsewhere

For charmworld we need to be able to run the charm proof code without
forking
out to subprocess. To do this, we need a more useable version of the
proof
code.

* Added a lib folder within scripts that contains proof.py and
__init__.py; in
short, it's a simple module.
* Moved the code in script/proof to script/lib/proof.py
* Broke the code into functions handling CLI argument parsing and actual
linting.
* Updated the set of printed error messages into a globally collect LINT
array. A global is less than ideal in this instance, but doing otherwise
would
require further re-architecting of the code, and isn't of high value
given
globals are already in play.
* Updated the error methods to simply add to the global LINT var. In
places
where crit is called, which expects sys.exit, the run method simply
returns,
ending further execution.
* Updated script/proof to import the proof code in lib. It then joins
the
returned array and outputs to stdout, per the original script, and exits
with
the global EXIT_CODE from lib.proof

https://code.launchpad.net/~jcsackett/charm-tools/libify-proof/+merge/143785

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7133054/

Affected files:
   A [revision details]
   A scripts/lib/__init__.py
   A scripts/lib/proof.py
   M scripts/proof

looks good... don't stop there! :)

I approve this message :)

Merge away ... This is pretty cool and, to quote Mark ... don't stop there!

Thanks,

Juan