Indicator Applet

Merge lp://staging/~jconti/indicator-applet/gnome3 into lp://staging/indicator-applet/0.5

  1. gnome3
  2. Merge into trunk.0.5
Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 408
Merged at revision: 392
Proposed branch: lp://staging/~jconti/indicator-applet/gnome3
Merge into: lp://staging/indicator-applet/0.5
Diff against target: 0 lines
To merge this branch: bzr merge lp://staging/~jconti/indicator-applet/gnome3
Reviewer Review Type Date Requested Status
Sebastian Geiger (community) code review and test Approve
Ted Gould (community) Approve
Dmitry Shachnev Pending
Marco Trevisan (Treviño) Pending
Review via email: mp+91927@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-11-01.

Description of the change

It looks like this branch is the only code base that works with GNOME3. Someone should take the responsibility to merge it and to make a new official release of it.

Without this release, the package is going to be dropped from Debian testing (unless we decide to package this branch directly, but it would be weird to have to do that...).

I put Ted as reviewer since he's the only upstream person that has worked on a port.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote : Posted in a previous version of this proposal

Builds and works for me™, though not for all (see https://bugs.launchpad.net/indicator-applet/+bug/724369/comments/27).

Note that my branch lp:~mitya57/indicator-session/fix-lp-881832 should be merged as well to get this working properly.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

Thanks for the work there, the people working on this code are at the ubuntu summit this week so it might take a few extra fays before getting a review but it's on the list of things to review

Revision history for this message
Jason Conti (jconti) wrote : Posted in a previous version of this proposal

I unfortunately converted the tabs to spaces in src/applet-main.c, which makes the diff kind of ugly, so I did the same with Ted's branch and posted a slightly better diff here: http://paste.ubuntu.com/725607/

It is worth noting that I took a look at Ted's branch after seeing the merge proposal, and it appears to work correctly with just the updated configure.ac, data/Makefile.am and src/tomboykeybinder.c (to silence a warning) from my branch, so that may be another way to go since I made quite a few possibly unwelcomed changes in my branch (such as using the logging functions from lightdm, since I found that the ones in indicator-applet tend to lose debug messages occasionally).

Revision history for this message
Dmitry Shachnev (mitya57) wrote : Posted in a previous version of this proposal

@Jason: I've updated indicator-session package in my ppa (it's now based on 0.7.3.1), can you please copy it to yours?

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Posted in a previous version of this proposal

Missing support for secondary-activate event (i.e. middle-click) and I'd suggest to use something like the indicator-priority that we used in unity-panel-service to show some app-indicators (like bluetooth, keyboard and network ones) in the proper place.

For the rest, it seems good.

review: Needs Fixing
Revision history for this message
Jason Conti (jconti) wrote : Posted in a previous version of this proposal

Added secondary-activate signal and name-hint for positioning support. I'll update the ppa tomorrow for testing.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Posted in a previous version of this proposal

Code looks good. Thanks.

I've also planned to make the indicator order configurable via gsettings, so stay tuned on this side.

review: Approve
Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

Great, thanks for the work on this. A few comments:

 * Please don't change the version number in configure.ac, it really confuses things if there are multiple version numbers in "the wild" so it's better just to have one place define it. I'll fix this on merge, no worries there.
 * Love that you changed the strings to #defines. I think that's a wonderful thing :-)

Thanks again for your work.

review: Approve
Revision history for this message
Sebastian Geiger (lanoxx) wrote : Posted in a previous version of this proposal

This was approved by Marco and Ted back in November, but the merge status is still set to 'Needs Review' could some body please update the status and tell if this is going to be merge upstream?

I also reviewed the code and can approve it. And also the ppa works on my oneric installation right now.

review: Approve (code review and test)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Sebastian Geiger (lanoxx) wrote :

Tested the merged code revision 393 of the official indicator-applet branch. Builds and runs without problems.

Rewiev: Approving after code review and test

review: Approve (code review and test)

Preview Diff

Empty

Subscribers

People subscribed via source and target branches