Merge lp://staging/~jcheun93/pantheon-terminal/fix-1169006 into lp://staging/~elementary-apps/pantheon-terminal/trunk
Proposed by
Jesse Cheun
| Status: | Rejected |
|---|---|
| Rejected by: | Danielle Foré |
| Proposed branch: | lp://staging/~jcheun93/pantheon-terminal/fix-1169006 |
| Merge into: | lp://staging/~elementary-apps/pantheon-terminal/trunk |
| Diff against target: |
412 lines (+333/-5) 4 files modified
CMakeLists.txt (+2/-1) src/PantheonTerminal.vala (+2/-2) src/PantheonTerminalWindow.vala (+11/-2) src/PreferencesDialog.vala (+318/-0) |
| To merge this branch: | bzr merge lp://staging/~jcheun93/pantheon-terminal/fix-1169006 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danielle Foré | Disapprove | ||
|
Review via email:
|
|||
Description of the change
Add Preferences Dialog to Terminal. Change basic settings like tab behaviors, font, theme etc. Right click terminal widget and select preference to access.
To post a comment you must log in.
Unmerged revisions
- 581. By Jesse Cheun
-
Add Preferences Dialog to Terminal. Right Click terminal widget to access.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Sorry Jesse. We don't want to add a prefs UI to Terminal