Merge lp://staging/~jbicha/ubuntu-themes/drop-input-keyboard-icon into lp://staging/ubuntu-themes

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 314
Proposed branch: lp://staging/~jbicha/ubuntu-themes/drop-input-keyboard-icon
Merge into: lp://staging/ubuntu-themes
Diff against target: 179 lines (+0/-170)
2 files modified
ubuntu-mono-dark/status/22/input-keyboard.svg (+0/-85)
ubuntu-mono-light/status/22/input-keyboard.svg (+0/-85)
To merge this branch: bzr merge lp://staging/~jbicha/ubuntu-themes/drop-input-keyboard-icon
Reviewer Review Type Date Requested Status
Dimitri John Ledkov (community) Approve
Review via email: mp+181793@code.staging.launchpad.net

Commit message

drop input-keyboard icons now that we have a proper indicator-keyboard

Description of the change

Alternatively, we could rename the icon to input-keyboard-panel or something in case anything else wants to use this icon. In Raring, this icon was used for gnome-settings-daemon's keyboard indicator and ibus' indicator, both of which have been replaced by indicator-keyboard which uses a language digraph instead of this icon.

To verify that this works correctly:
1. Build (you'll need to update debian/changelog with a higher version number, 20130823 instead of 20130812 for the build to not attempt to merge with the existing .orig.tar.gz)
2. edit /usr/share/applications/gnome-keyboard-panel.desktop
and set Icon=input-keyboard
3. sudo update-desktop-database
4. Open gnome-control-center and verify that the Keyboard icon looks fine.

We'll just need to do an upload of gnome-control-center the same day as this ubuntu-themes upload
to avoid the icon being broken.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I think ubiquity's keyboard indicators still use this.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Can you verify?

If ubiquity does need it, could the icon at least be renamed so that it doesn't cause a conflict in gnome-control-center (bug 862027)?

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Looks like ubiquity is not using that icon. Accepting.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches