Merge lp://staging/~jbicha/ubiquity/update-updates-page into lp://staging/ubiquity

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 6600
Proposed branch: lp://staging/~jbicha/ubiquity/update-updates-page
Merge into: lp://staging/ubiquity
Diff against target: 79400 lines (+16321/-9543)
137 files modified
debian/changelog (+5/-0)
debian/real-po/aa.po (+119/-72)
debian/real-po/ace.po (+111/-68)
debian/real-po/af.po (+126/-72)
debian/real-po/am.po (+122/-72)
debian/real-po/an.po (+111/-68)
debian/real-po/ar.po (+126/-72)
debian/real-po/as.po (+111/-68)
debian/real-po/ast.po (+126/-72)
debian/real-po/az.po (+111/-68)
debian/real-po/be.po (+126/-72)
debian/real-po/bg.po (+126/-72)
debian/real-po/bn.po (+126/-72)
debian/real-po/bo.po (+122/-72)
debian/real-po/br.po (+119/-72)
debian/real-po/bs.po (+126/-72)
debian/real-po/ca.po (+126/-72)
debian/real-po/ca@valencia.po (+126/-72)
debian/real-po/ce.po (+111/-68)
debian/real-po/ckb.po (+111/-68)
debian/real-po/cs.po (+126/-72)
debian/real-po/csb.po (+122/-72)
debian/real-po/cv.po (+111/-68)
debian/real-po/cy.po (+126/-72)
debian/real-po/da.po (+126/-72)
debian/real-po/de.po (+126/-72)
debian/real-po/dv.po (+116/-71)
debian/real-po/dz.po (+111/-68)
debian/real-po/el.po (+126/-72)
debian/real-po/en_AU.po (+158/-104)
debian/real-po/en_CA.po (+153/-99)
debian/real-po/en_GB.po (+158/-104)
debian/real-po/eo.po (+126/-72)
debian/real-po/es.po (+126/-72)
debian/real-po/et.po (+126/-72)
debian/real-po/eu.po (+126/-72)
debian/real-po/fa.po (+122/-72)
debian/real-po/fi.po (+126/-72)
debian/real-po/fil.po (+122/-72)
debian/real-po/fo.po (+119/-72)
debian/real-po/fr.po (+126/-72)
debian/real-po/fr_CA.po (+126/-72)
debian/real-po/frp.po (+113/-68)
debian/real-po/fy.po (+116/-71)
debian/real-po/ga.po (+120/-71)
debian/real-po/gd.po (+126/-72)
debian/real-po/gl.po (+126/-72)
debian/real-po/gu.po (+116/-71)
debian/real-po/gv.po (+111/-68)
debian/real-po/he.po (+126/-72)
debian/real-po/hi.po (+126/-72)
debian/real-po/hr.po (+126/-72)
debian/real-po/hu.po (+126/-72)
debian/real-po/hy.po (+126/-72)
debian/real-po/ia.po (+126/-72)
debian/real-po/id.po (+126/-72)
debian/real-po/is.po (+126/-72)
debian/real-po/it.po (+126/-72)
debian/real-po/ja.po (+126/-72)
debian/real-po/ka.po (+116/-71)
debian/real-po/kab.po (+111/-68)
debian/real-po/kk.po (+126/-72)
debian/real-po/kl.po (+111/-68)
debian/real-po/km.po (+126/-72)
debian/real-po/kn.po (+116/-71)
debian/real-po/ko.po (+126/-72)
debian/real-po/ku.po (+126/-72)
debian/real-po/kw.po (+120/-71)
debian/real-po/ky.po (+122/-72)
debian/real-po/lb.po (+116/-71)
debian/real-po/lo.po (+111/-68)
debian/real-po/lt.po (+126/-72)
debian/real-po/lv.po (+126/-72)
debian/real-po/mg.po (+116/-71)
debian/real-po/mhr.po (+116/-71)
debian/real-po/mk.po (+116/-71)
debian/real-po/ml.po (+122/-73)
debian/real-po/mr.po (+126/-72)
debian/real-po/ms.po (+126/-72)
debian/real-po/my.po (+122/-72)
debian/real-po/nb.po (+126/-72)
debian/real-po/nds.po (+111/-68)
debian/real-po/ne.po (+126/-72)
debian/real-po/nl.po (+126/-72)
debian/real-po/nl_NL.po (+111/-68)
debian/real-po/nn.po (+122/-72)
debian/real-po/ny.po (+111/-68)
debian/real-po/oc.po (+126/-72)
debian/real-po/oj.po (+111/-68)
debian/real-po/om.po (+111/-68)
debian/real-po/or.po (+111/-68)
debian/real-po/os.po (+116/-71)
debian/real-po/pa.po (+122/-72)
debian/real-po/pl.po (+126/-72)
debian/real-po/pt.po (+126/-72)
debian/real-po/pt_BR.po (+126/-72)
debian/real-po/ro.po (+126/-72)
debian/real-po/ru.po (+126/-72)
debian/real-po/sa.po (+123/-72)
debian/real-po/sco.po (+111/-68)
debian/real-po/sd.po (+126/-72)
debian/real-po/se.po (+115/-69)
debian/real-po/shn.po (+111/-68)
debian/real-po/si.po (+124/-74)
debian/real-po/sk.po (+126/-72)
debian/real-po/sl.po (+126/-72)
debian/real-po/sn.po (+116/-71)
debian/real-po/sq.po (+126/-72)
debian/real-po/sr.po (+126/-72)
debian/real-po/sv.po (+126/-72)
debian/real-po/sw.po (+111/-68)
debian/real-po/ta.po (+126/-72)
debian/real-po/ta_LK.po (+116/-71)
debian/real-po/te.po (+122/-72)
debian/real-po/templates.pot (+111/-68)
debian/real-po/tet.po (+116/-71)
debian/real-po/tg.po (+126/-72)
debian/real-po/th.po (+126/-72)
debian/real-po/tl.po (+111/-68)
debian/real-po/tr.po (+126/-72)
debian/real-po/tt.po (+116/-71)
debian/real-po/ug.po (+126/-72)
debian/real-po/uk.po (+126/-72)
debian/real-po/ur.po (+116/-71)
debian/real-po/uz.po (+126/-72)
debian/real-po/vec.po (+126/-72)
debian/real-po/vi.po (+126/-72)
debian/real-po/wae.po (+111/-68)
debian/real-po/wo.po (+111/-68)
debian/real-po/xh.po (+111/-68)
debian/real-po/zh_CN.po (+126/-72)
debian/real-po/zh_HK.po (+126/-72)
debian/real-po/zh_TW.po (+126/-72)
debian/ubiquity.templates (+38/-3)
gui/gtk/stepPrepare.ui (+137/-62)
gui/qt/stepPrepare.ui (+59/-4)
ubiquity/plugins/ubi-prepare.py (+5/-4)
To merge this branch: bzr merge lp://staging/~jbicha/ubiquity/update-updates-page
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Approve
Review via email: mp+341912@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Rik Mills (rikmills) wrote :

Please see my comment and screenshots in the related bug.

With respect to Kubuntu, and testing the packages from Jeremy's PPA, this MP in it's current state represents a regression in the KDE front end, without any on the benefits seen in the GTK one.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Agreed, a change in a frontend cannot introduce a regression in another frontend. Please update the KDE frontend to match the design too.

review: Needs Fixing
6598. By Rik Mills

[ Rik Mills ]
Mark the sddm.conf file for OEM so that it can be removed by oem-config
if unchanged.

6599. By Jean-Baptiste Lallement

* ubiquity/frontend/{gtk,kde}_ui.py:
  - Set a marker when user is done to know how long the last screen took or if
    the user delayed the whole install process. Thanks didrocks.

6600. By Jeremy Bícha

Update "Updates and Other Software" page to match the spec (LP: #1758082)

6601. By Rik Mills

Update KDE/Qt "Updates and Other Software" page in line with GTK changes,
with some tweaks appropriate for Kubuntu usage in Bionic

6602. By Jeremy Bícha

update ubiquity.templates for previous changes

6603. By Jeremy Bícha

Run debconf-updatepo for previous changes

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks Jeremy and Rik for your work.

It all looks goo to me. I tested on Ubuntu, Kubuntu and Kylin and didn't find any issue.

Although the telemetry file generated for Kubuntu is not fully useful due to the name of the stages. Several steps are called "Form" or "page" without any indication of which form or page.

{
  "Media": "Kubuntu 18.04 LTS \"Bionic Beaver\" - Alpha amd64 (20180328)",
  "Type": "KDE",
  "PartitionMethod": "use_device",
  "DownloadUpdates": false,
  "Language": "en",
  "Minimal": true,
  "RestrictedAddons": true,
  "Stages": {
    "0": "language",
    "1": "language",
    "6": "page",
    "9": "Form",
    "44": "Form",
    "58": "start_install",
    "60": "page",
    "62": "Form",
    "73": "user_done",
    "785": "done"
  }
}

Approved! Thanks again!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: