Friends

Merge lp://staging/~jbicha/friends/build-depend-on-dev-not-gir into lp://staging/friends

  1. build-depend-on-dev-not-gir
  2. Merge into trunk
Proposed by Jeremy Bícha
Status: Rejected
Rejected by: Ken VanDine
Proposed branch: lp://staging/~jbicha/friends/build-depend-on-dev-not-gir
Merge into: lp://staging/friends
Diff against target: 48 lines (+12/-17)
1 file modified
debian/control (+12/-17)
To merge this branch: bzr merge lp://staging/~jbicha/friends/build-depend-on-dev-not-gir
Reviewer Review Type Date Requested Status
Ken VanDine Disapprove
Review via email: mp+168044@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Is this really desirable? Since it really only depends on having the gir installed for the tests, it doesn't actually depend on any files provided by those dev packages. Seems like it just adds more overhead in the build to install more stuff than is really required. Or is this part of a bigger effort for consistency?

review: Needs Information
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Mmm, I guess it's mostly a style thing since it doesn't actually change anything in the build.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Also it could make backports more difficult since those 4 libraries I mentioned in the initial comment are missing their -gir dependency in Raring.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

With the amount of times this gets rebuilt automatically, I'd say lets not approve this, it would just add a lot of extra churn installing the extra packages and their depends during build. I did go through those other MP's and added approvals for them. Thanks!

review: Disapprove

Unmerged revisions

205. By Jeremy Bícha

build-depend on -dev packages instead of gir- packages

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: