Merge lp://staging/~jbicha/firefox/dont-depend-on-gtk2 into lp://staging/~mozillateam/firefox/firefox-beta.artful
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~jbicha/firefox/dont-depend-on-gtk2 |
| Merge into: | lp://staging/~mozillateam/firefox/firefox-beta.artful |
| Diff against target: |
14 lines (+4/-0) 1 file modified
debian/build/rules.mk (+4/-0) |
| To merge this branch: | bzr merge lp://staging/~jbicha/firefox/dont-depend-on-gtk2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rico Tzschichholz | Pending | ||
|
Review via email:
|
|||
Description of the change
Firefox has only one file that naturally depends on gtk2:
/usr/lib/
I think that file is only used by the Flash plugin.
See https:/
All the Flash plugin packages in Ubuntu and Debian already depend on libgtk2.0-0
- adobe-flashplugin
- flashplugin-
- pepperflashplug
Therefore, I propose we use the same hack we've used in several other packages to drop the depends on gtk2. The final packages in the default 18.04 install to pull in gtk2 are Firefox, Thunderbird, and debconf (for libgtk2-perl). The tracker bug for that issue is LP: #1585903
The only risk I see is that it is possible for someone to manually try to install Flash without using the Ubuntu packages but I don't understand why anyone would do that and I don't think we should worry about that use case.
I haven't tested Thunderbird yet. I believe the change is unsafe on Thunderbird 52, but I think it would be fine for Thunderbird 57 or 58 Beta. Based on the release schedule, I think we could ship 59 (Beta?) with Ubuntu 18.04 LTS.
| Rico Tzschichholz (ricotz) wrote | # |
| Jeremy Bícha (jbicha) wrote | # |
Unmerged revisions
- 1218. By Jeremy Bícha
-
Don't depend on gtk2. gtk2 is only needed by Flash but all the Flash
packages already depend on gtk2.
Merged into https:/